Bug 184820

Summary: Use WindowProxy in DOMWindow.idl
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: BindingsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, dbates, esprehn+autocc, ews-watchlist, kangil.han, kondapallykalyan, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2018-04-20 08:37:24 PDT
Use WindowProxy in DOMWindow.idl to match the specification more closely.
Attachments
Patch (18.53 KB, patch)
2018-04-20 08:38 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (19.66 KB, patch)
2018-04-20 14:45 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2018-04-20 08:38:35 PDT
Created attachment 338430 [details] Patch
Sam Weinig
Comment 2 2018-04-20 10:53:27 PDT
Comment on attachment 338430 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=338430&action=review > Source/WebCore/page/DOMWindow.cpp:2305 > +WindowProxy* DOMWindow::open(DOMWindow& activeWindow, DOMWindow& firstWindow, const String& urlString, const AtomicString& frameName, const String& windowFeaturesString) I'm a little worried about this losing it's RefPtr'ness. I think giving WindowProxy ref() and deref() methods, that just ref/deref the underlying AbstractFrame and making this return a RefPtr<WindowProxy> would be safer. What do you think?
Chris Dumez
Comment 3 2018-04-20 10:57:26 PDT
(In reply to Sam Weinig from comment #2) > Comment on attachment 338430 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=338430&action=review > > > Source/WebCore/page/DOMWindow.cpp:2305 > > +WindowProxy* DOMWindow::open(DOMWindow& activeWindow, DOMWindow& firstWindow, const String& urlString, const AtomicString& frameName, const String& windowFeaturesString) > > I'm a little worried about this losing it's RefPtr'ness. I think giving > WindowProxy ref() and deref() methods, that just ref/deref the underlying > AbstractFrame and making this return a RefPtr<WindowProxy> would be safer. > What do you think? Oh, I had similar concerns but did not want to have WindowProxy subclass RefCounted. Your idea sounds good.
Chris Dumez
Comment 4 2018-04-20 14:45:21 PDT
Created attachment 338463 [details] Patch
WebKit Commit Bot
Comment 5 2018-04-20 16:48:55 PDT
Comment on attachment 338463 [details] Patch Clearing flags on attachment: 338463 Committed r230867: <https://trac.webkit.org/changeset/230867>
WebKit Commit Bot
Comment 6 2018-04-20 16:48:57 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2018-04-20 16:49:16 PDT
<rdar://problem/39613880>
Note You need to log in before you can comment on or make changes to this bug.