Bug 184797

Summary: Rename JSDOMWindowProxy to JSWindowProxy
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: BindingsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, dbates, ews-watchlist, ggaren, mkwst, rniwa, ryanhaddad, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Chris Dumez 2018-04-19 15:21:12 PDT 
Rename JSDOMWindowProxy to JSWindowProxy for consistency with WindowProxy.
Comment 1 Chris Dumez 2018-04-19 15:22:48 PDT 
Created attachment 338369 [details]
Patch
Comment 2 Chris Dumez 2018-04-19 15:25:07 PDT 
Created attachment 338370 [details]
Patch
Comment 3 WebKit Commit Bot 2018-04-19 19:15:45 PDT 
Comment on attachment 338370 [details]
Patch

Clearing flags on attachment: 338370

Committed r230831: <https://trac.webkit.org/changeset/230831>
Comment 4 WebKit Commit Bot 2018-04-19 19:15:47 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-04-19 19:16:25 PDT 
<rdar://problem/39585235>
Comment 6 Ryan Haddad 2018-04-20 08:41:33 PDT 
This change broke the Windows build:
https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/8921
Comment 7 Chris Dumez 2018-04-20 09:03:59 PDT 
(In reply to Ryan Haddad from comment #6)
> This change broke the Windows build:
> https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/
> 8921

Thanks, will fix now.
Comment 8 Chris Dumez 2018-04-20 09:33:21 PDT 
(In reply to Chris Dumez from comment #7)
> (In reply to Ryan Haddad from comment #6)
> > This change broke the Windows build:
> > https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/
> > 8921
> 
> Thanks, will fix now.

Fixed in https://trac.webkit.org/r230840.