Bug 184797

Summary: Rename JSDOMWindowProxy to JSWindowProxy
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: BindingsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, dbates, ews-watchlist, ggaren, mkwst, rniwa, ryanhaddad, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2018-04-19 15:21:12 PDT
Rename JSDOMWindowProxy to JSWindowProxy for consistency with WindowProxy.
Attachments
Patch (63.58 KB, patch)
2018-04-19 15:22 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (67.96 KB, patch)
2018-04-19 15:25 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2018-04-19 15:22:48 PDT
Created attachment 338369 [details] Patch
Chris Dumez
Comment 2 2018-04-19 15:25:07 PDT
Created attachment 338370 [details] Patch
WebKit Commit Bot
Comment 3 2018-04-19 19:15:45 PDT
Comment on attachment 338370 [details] Patch Clearing flags on attachment: 338370 Committed r230831: <https://trac.webkit.org/changeset/230831>
WebKit Commit Bot
Comment 4 2018-04-19 19:15:47 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2018-04-19 19:16:25 PDT
<rdar://problem/39585235>
Ryan Haddad
Comment 6 2018-04-20 08:41:33 PDT
This change broke the Windows build: https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/8921
Chris Dumez
Comment 7 2018-04-20 09:03:59 PDT
(In reply to Ryan Haddad from comment #6) > This change broke the Windows build: > https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/ > 8921 Thanks, will fix now.
Chris Dumez
Comment 8 2018-04-20 09:33:21 PDT
(In reply to Chris Dumez from comment #7) > (In reply to Ryan Haddad from comment #6) > > This change broke the Windows build: > > https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/ > > 8921 > > Thanks, will fix now. Fixed in https://trac.webkit.org/r230840.
Note You need to log in before you can comment on or make changes to this bug.