Bug 184759

Summary: Buildbots using Python zipfile should enable compression
Product: WebKit Reporter: Ross Kirsling <ross.kirsling>
Component: New BugsAssignee: Ross Kirsling <ross.kirsling>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, don.olmstead, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Ross Kirsling
Reported 2018-04-18 14:55:10 PDT
Buildbots using Python zipfile should enable compression
Attachments
Patch (1.40 KB, patch)
2018-04-18 14:57 PDT, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ross Kirsling
Comment 1 2018-04-18 14:57:15 PDT
Created attachment 338266 [details] Patch
Lucas Forschler
Comment 2 2018-04-18 14:59:13 PDT
Comment on attachment 338266 [details] Patch cool. Do you know offhand which ports call createZipManually? is it only 'win' and 'wincairo' ?
Don Olmstead
Comment 3 2018-04-18 15:00:36 PDT
Only WinCairo. AppleWin is using cygwin.
Ross Kirsling
Comment 4 2018-04-18 15:03:10 PDT
Right, Darwin uses `ditto` and Linux/Cygwin use the `zip` command.
WebKit Commit Bot
Comment 5 2018-04-18 16:40:41 PDT
Comment on attachment 338266 [details] Patch Clearing flags on attachment: 338266 Committed r230790: <https://trac.webkit.org/changeset/230790>
WebKit Commit Bot
Comment 6 2018-04-18 16:40:42 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2018-04-18 16:58:00 PDT
<rdar://problem/39546871>
Note You need to log in before you can comment on or make changes to this bug.