Bug 184676 – AX: AOM: Add ARIA IDL Attribute Reflection

• Component: Accessibility
• Status: RESOLVED FIXED

[James Craig]

AOM: Add ARIA IDL Attribute Reflection

This work spun out of AOM into ARIA and is currently tracked here:
https://github.com/w3c/aria/pull/708

[Radar WebKit Bug Importer]

<rdar://problem/39476882>

[James Craig]

Now in ARIA 1.2 ED:
https://w3c.github.io/aria/#idl-interface

[Nan Wang]

Created attachment 346133 [details]
patch

[EWS Watchlist]

Comment on attachment 346133 [details]
patch

Attachment 346133 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8706111

New failing tests:
accessibility/ARIA-reflection.html
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-video.html

[EWS Watchlist]

Created attachment 346139 [details]
Archive of layout-test-results from ews206 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[Nan Wang]

Created attachment 346144 [details]
patch

[chris fleizach]

Comment on attachment 346144 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346144&action=review

> Source/WebCore/accessibility/AriaAttributes.idl:27
> +    EnabledAtRuntime=AccessibilityObjectModel,

I don't think we should tie this to AOM. If we're going to tie this to any feature, it should be a new one (ARIAReflection)

> Source/WebCore/accessibility/AriaAttributes.idl:29
> +] interface AriaAttributes {

should this bee ARIAAttributes

[Nan Wang]

Comment on attachment 346144 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346144&action=review

>> Source/WebCore/accessibility/AriaAttributes.idl:27
>> +    EnabledAtRuntime=AccessibilityObjectModel,
> 
> I don't think we should tie this to AOM. If we're going to tie this to any feature, it should be a new one (ARIAReflection)

Ok, do you think we should create a new runtime flag?

>> Source/WebCore/accessibility/AriaAttributes.idl:29
>> +] interface AriaAttributes {
> 
> should this bee ARIAAttributes

This is in the spec.

[chris fleizach]

Comment on attachment 346144 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346144&action=review

>>> Source/WebCore/accessibility/AriaAttributes.idl:27
>>> +    EnabledAtRuntime=AccessibilityObjectModel,
>> 
>> I don't think we should tie this to AOM. If we're going to tie this to any feature, it should be a new one (ARIAReflection)
> 
> Ok, do you think we should create a new runtime flag?

seems like it

[Nan Wang]

Created attachment 346283 [details]
patch

Added a new runtime flag and turned it on by default.

[chris fleizach]

Comment on attachment 346283 [details]
patch

LGTM. let's check if Ryosuke also happy with this

[Ryosuke Niwa]

Comment on attachment 346283 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346283&action=review

> Source/WebKit/Shared/WebPreferences.yaml:1236
> +  defaultValue: true

Is our implementation complete? Is it spec compliant & ready to ship?
Otherwise, we shouldn't turn this feature on by default.

> Source/WebKit/Shared/WebPreferences.yaml:1237
> +  webcoreBinding: RuntimeEnabledFeatures

This should be an experimental feature instead.

[Nan Wang]

Comment on attachment 346283 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346283&action=review

>> Source/WebKit/Shared/WebPreferences.yaml:1236
>> +  defaultValue: true
> 
> Is our implementation complete? Is it spec compliant & ready to ship?
> Otherwise, we shouldn't turn this feature on by default.

Yes this is complete.

>> Source/WebKit/Shared/WebPreferences.yaml:1237
>> +  webcoreBinding: RuntimeEnabledFeatures
> 
> This should be an experimental feature instead.

Sure I will add this to experimental feature.

[Nan Wang]

Committed r234482: <https://trac.webkit.org/changeset/234482>