Bug 184611

Summary: [WK1] Layout Test legacy-animation-engine/compositing/backing/transform-transition-from-outside-view.html is a flaky failure
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: Tools / TestsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, graouts, simon.fraser, tsavell, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=184566
https://bugs.webkit.org/show_bug.cgi?id=203225
Attachments:
Description Flags
Patch zalan: review+, commit-queue: commit-queue-

Ryan Haddad
Reported 2018-04-13 17:06:43 PDT
The following layout test is a flaky failure on High Sierra Debug WK1 legacy-animation-engine/compositing/backing/transform-transition-from-outside-view.html Flakiness Dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=legacy-animation-engine%2Fcompositing%2Fbacking%2Ftransform-transition-from-outside-view.html --- /Volumes/Data/slave/highsierra-debug-tests-wk1/build/layout-test-results/legacy-animation-engine/compositing/backing/transform-transition-from-outside-view-expected.txt +++ /Volumes/Data/slave/highsierra-debug-tests-wk1/build/layout-test-results/legacy-animation-engine/compositing/backing/transform-transition-from-outside-view-actual.txt @@ -19,7 +19,7 @@ (offsetFromRenderer width=-14 height=-14) (bounds 48.00 48.00) (drawsContent 1) - (backingStoreAttached 1) + (backingStoreAttached 0) ) ) )
Attachments
Patch (4.26 KB, patch)
2019-10-21 16:05 PDT, Simon Fraser (smfr) 		zalan: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Truitt Savell
Comment 1 2018-07-20 11:37:08 PDT
This test is still Flakey on High Sierra Debug WK1 with the same failure.
Alexey Proskuryakov
Comment 2 2019-05-11 16:11:47 PDT
Still flaky on WK1, but the diff is different. --- /Volumes/Data/slave/highsierra-debug-tests-wk1/build/layout-test-results/compositing/layer-creation/fixed-overlap-extent-expected.txt +++ /Volumes/Data/slave/highsierra-debug-tests-wk1/build/layout-test-results/compositing/layer-creation/fixed-overlap-extent-actual.txt @@ -6,7 +6,7 @@ (GraphicsLayer (bounds 1108.00 1021.00) (contentsOpaque 1) - (children 869 + (children 841 (GraphicsLayer (offsetFromRenderer width=-14 height=-14) (position 46.00 106.00) @@ -164,11 +164,6 @@ (contentsOpaque 1) ) (GraphicsLayer - (position 48.00 713.00) - (bounds 10.00 10.00) - (contentsOpaque 1) - ) - (GraphicsLayer (position 68.00 113.00) (bounds 10.00 10.00) (contentsOpaque 1) @@ -319,11 +314,6 @@ (contentsOpaque 1) ) (GraphicsLayer - (position 68.00 713.00) - (bounds 10.00 10.00) - (contentsOpaque 1) - ) - (GraphicsLayer (position 88.00 113.00) (bounds 10.00 10.00) (contentsOpaque 1) @@ -474,11 +464,6 @@ (contentsOpaque 1) ) (GraphicsLayer - (position 88.00 713.00) - (bounds 10.00 10.00) - (contentsOpaque 1) - ) - (GraphicsLayer (position 108.00 113.00) (bounds 10.00 10.00) (contentsOpaque 1) @@ -629,11 +614,6 @@ (contentsOpaque 1) ) (GraphicsLayer - (position 108.00 713.00) - (bounds 10.00 10.00) - (contentsOpaque 1) - ) - (GraphicsLayer (position 128.00 113.00) (bounds 10.00 10.00) (contentsOpaque 1) @@ -784,11 +764,6 @@ (contentsOpaque 1) ) (GraphicsLayer - (position 128.00 713.00) - (bounds 10.00 10.00) - (contentsOpaque 1) - ) - (GraphicsLayer (position 148.00 113.00) (bounds 10.00 10.00) (contentsOpaque 1) @@ -939,11 +914,6 @@ (contentsOpaque 1) ) (GraphicsLayer - (position 148.00 713.00) - (bounds 10.00 10.00) - (contentsOpaque 1) - ) - (GraphicsLayer (position 168.00 113.00) (bounds 10.00 10.00) (contentsOpaque 1) @@ -1094,11 +1064,6 @@ (contentsOpaque 1) ) (GraphicsLayer - (position 168.00 713.00) - (bounds 10.00 10.00) - (contentsOpaque 1) - ) - (GraphicsLayer (position 188.00 113.00) (bounds 10.00 10.00) (contentsOpaque 1) @@ -1249,11 +1214,6 @@ (contentsOpaque 1) ) (GraphicsLayer - (position 188.00 713.00) - (bounds 10.00 10.00) - (contentsOpaque 1) - ) - (GraphicsLayer (position 208.00 113.00) (bounds 10.00 10.00) (contentsOpaque 1) @@ -1404,11 +1364,6 @@ (contentsOpaque 1) ) (GraphicsLayer - (position 208.00 713.00) - (bounds 10.00 10.00) - (contentsOpaque 1) - ) - (GraphicsLayer (position 228.00 113.00) (bounds 10.00 10.00) (contentsOpaque 1) @@ -1559,11 +1514,6 @@ (contentsOpaque 1) ) (GraphicsLayer - (position 228.00 713.00) - (bounds 10.00 10.00) - (contentsOpaque 1) - ) - (GraphicsLayer (position 248.00 113.00) (bounds 10.00 10.00) (contentsOpaque 1) @@ -1714,11 +1664,6 @@ (contentsOpaque 1) ) (GraphicsLayer - (position 248.00 713.00) - (bounds 10.00 10.00) - (contentsOpaque 1) - ) - (GraphicsLayer (position 268.00 113.00) (bounds 10.00 10.00) (contentsOpaque 1) @@ -1869,11 +1814,6 @@ (contentsOpaque 1) ) (GraphicsLayer - (position 268.00 713.00) - (bounds 10.00 10.00) - (contentsOpaque 1) - ) - (GraphicsLayer (position 288.00 113.00) (bounds 10.00 10.00) (contentsOpaque 1) @@ -2024,11 +1964,6 @@ (contentsOpaque 1) ) (GraphicsLayer - (position 288.00 713.00) - (bounds 10.00 10.00) - (contentsOpaque 1) - ) - (GraphicsLayer (position 308.00 113.00) (bounds 10.00 10.00) (contentsOpaque 1) @@ -2179,11 +2114,6 @@ (contentsOpaque 1) ) (GraphicsLayer - (position 308.00 713.00) - (bounds 10.00 10.00) - (contentsOpaque 1) - ) - (GraphicsLayer (position 328.00 113.00) (bounds 10.00 10.00) (contentsOpaque 1) @@ -2334,11 +2264,6 @@ (contentsOpaque 1) ) (GraphicsLayer - (position 328.00 713.00) - (bounds 10.00 10.00) - (contentsOpaque 1) - ) - (GraphicsLayer (position 348.00 113.00) (bounds 10.00 10.00) (contentsOpaque 1) @@ -2489,11 +2414,6 @@ (contentsOpaque 1) ) (GraphicsLayer - (position 348.00 713.00) - (bounds 10.00 10.00) - (contentsOpaque 1) - ) - (GraphicsLayer (position 368.00 113.00) (bounds 10.00 10.00) (contentsOpaque 1) @@ -2644,11 +2564,6 @@ (contentsOpaque 1) ) (GraphicsLayer - (position 368.00 713.00) - (bounds 10.00 10.00) - (contentsOpaque 1) - ) - (GraphicsLayer (position 388.00 113.00) (bounds 10.00 10.00) (contentsOpaque 1) @@ -2799,11 +2714,6 @@ (contentsOpaque 1) ) (GraphicsLayer - (position 388.00 713.00) - (bounds 10.00 10.00) - (contentsOpaque 1) - ) - (GraphicsLayer (position 408.00 113.00) (bounds 10.00 10.00) (contentsOpaque 1) @@ -2954,11 +2864,6 @@ (contentsOpaque 1) ) (GraphicsLayer - (position 408.00 713.00) - (bounds 10.00 10.00) - (contentsOpaque 1) - ) - (GraphicsLayer (position 428.00 113.00) (bounds 10.00 10.00) (contentsOpaque 1) @@ -3109,11 +3014,6 @@ (contentsOpaque 1) ) (GraphicsLayer - (position 428.00 713.00) - (bounds 10.00 10.00) - (contentsOpaque 1) - ) - (GraphicsLayer (position 448.00 113.00) (bounds 10.00 10.00) (contentsOpaque 1) @@ -3264,11 +3164,6 @@ (contentsOpaque 1) ) (GraphicsLayer - (position 448.00 713.00) - (bounds 10.00 10.00) - (contentsOpaque 1) - ) - (GraphicsLayer (position 468.00 113.00) (bounds 10.00 10.00) (contentsOpaque 1) @@ -3419,11 +3314,6 @@ (contentsOpaque 1) ) (GraphicsLayer - (position 468.00 713.00) - (bounds 10.00 10.00) - (contentsOpaque 1) - ) - (GraphicsLayer (position 488.00 113.00) (bounds 10.00 10.00) (contentsOpaque 1) @@ -3574,11 +3464,6 @@ (contentsOpaque 1) ) (GraphicsLayer - (position 488.00 713.00) - (bounds 10.00 10.00) - (contentsOpaque 1) - ) - (GraphicsLayer (position 508.00 113.00) (bounds 10.00 10.00) (contentsOpaque 1) @@ -3729,11 +3614,6 @@ (contentsOpaque 1) ) (GraphicsLayer - (position 508.00 713.00) - (bounds 10.00 10.00) - (contentsOpaque 1) - ) - (GraphicsLayer (position 528.00 113.00) (bounds 10.00 10.00) (contentsOpaque 1) @@ -3884,11 +3764,6 @@ (contentsOpaque 1) ) (GraphicsLayer - (position 528.00 713.00) - (bounds 10.00 10.00) - (contentsOpaque 1) - ) - (GraphicsLayer (position 548.00 113.00) (bounds 10.00 10.00) (contentsOpaque 1) @@ -4039,11 +3914,6 @@ (contentsOpaque 1) ) (GraphicsLayer - (position 548.00 713.00) - (bounds 10.00 10.00) - (contentsOpaque 1) - ) - (GraphicsLayer (position 568.00 113.00) (bounds 10.00 10.00) (contentsOpaque 1) @@ -4194,11 +4064,6 @@ (contentsOpaque 1) ) (GraphicsLayer - (position 568.00 713.00) - (bounds 10.00 10.00) - (contentsOpaque 1) - ) - (GraphicsLayer (position 588.00 113.00) (bounds 10.00 10.00) (contentsOpaque 1) @@ -4345,11 +4210,6 @@ ) (GraphicsLayer (position 588.00 693.00) - (bounds 10.00 10.00) - (contentsOpaque 1) - ) - (GraphicsLayer - (position 588.00 713.00) (bounds 10.00 10.00) (contentsOpaque 1) )
Radar WebKit Bug Importer
Comment 3 2019-05-11 16:12:03 PDT
<rdar://problem/50697790>
Simon Fraser (smfr)
Comment 4 2019-10-21 16:05:54 PDT
Created attachment 381474 [details] Patch
Simon Fraser (smfr)
Comment 5 2019-10-21 16:06:22 PDT
That's a different test.
WebKit Commit Bot
Comment 6 2019-10-21 18:12:35 PDT
Comment on attachment 381474 [details] Patch Rejecting attachment 381474 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 381474, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=381474&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=184611&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Updating working directory Processing patch 381474 from bug 184611. Fetching: https://bugs.webkit.org/attachment.cgi?id=381474 Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog ERROR from SVN: Item is out of date: File '/trunk/LayoutTests/ChangeLog' is out of date W: 65427d1294bf822585f76290fcb5bf295e5592d7 and refs/remotes/origin/master differ, using rebase: :040000 040000 1abb0ad4760b8fbe5ace2f23fbb0cd7d77ee2c74 a0d2100a84e6425b803ebedce5eccfa54cf0301f M LayoutTests Current branch master is up to date. ERROR: Not all changes have been committed into SVN, however the committed ones (if any) seem to be successfully integrated into the working tree. Please see the above messages for details. Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog ERROR from SVN: Item is out of date: File '/trunk/LayoutTests/ChangeLog' is out of date W: 65427d1294bf822585f76290fcb5bf295e5592d7 and refs/remotes/origin/master differ, using rebase: :040000 040000 1abb0ad4760b8fbe5ace2f23fbb0cd7d77ee2c74 a0d2100a84e6425b803ebedce5eccfa54cf0301f M LayoutTests Current branch master is up to date. ERROR: Not all changes have been committed into SVN, however the committed ones (if any) seem to be successfully integrated into the working tree. Please see the above messages for details. Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Updating OpenSource From https://git.webkit.org/git/WebKit fa090c6dde0..e96931ea50c master -> origin/master First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Total errors found: 0 in 0 files Full output: https://webkit-queues.webkit.org/results/13160526
Simon Fraser (smfr)
Comment 7 2019-10-21 20:58:00 PDT
https://trac.webkit.org/changeset/251412/webkit
Antoine Quint
Comment 8 2019-10-24 01:47:02 PDT
I see this test is also listed as a non-WK1 flaky failure, see webkit.org/b/203225 and webkit.org/b/184482.
Antoine Quint
Comment 9 2019-10-24 01:48:03 PDT
Actually, just webkit.org/b/203225.
Note You need to log in before you can comment on or make changes to this bug.