Bug 184599

Summary: Remove code for compilers that did not support NSDMI for aggregates
Product: WebKit Reporter: Daniel Bates <dbates>
Component: WebCore Misc.Assignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, pvollan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch pvollan: review+

Daniel Bates
Reported 2018-04-13 11:15:45 PDT
According to Per Arne Vollan we updated the bots and EWS to a version of Visual Studio that supports non-static data member initializers (NSDMI) for aggregates. And Visual Studio was the only compiler that we needed to workaround. So, lets remove the workarounds.
Attachments
Patch (20.73 KB, patch)
2018-04-13 11:19 PDT, Daniel Bates 		pvollan: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2018-04-13 11:19:27 PDT
Created attachment 337910 [details] Patch
Per Arne Vollan
Comment 2 2018-04-13 12:00:04 PDT
Comment on attachment 337910 [details] Patch R=me.
Per Arne Vollan
Comment 3 2018-04-14 08:02:54 PDT
I think there might be places where we added constructors, but forgot to add the !COMPILER_SUPPORTS(NSDMI_FOR_AGGREGATES) compile guard. Should we attempt to find those instances?
Daniel Bates
Comment 4 2018-04-14 09:30:57 PDT
(In reply to Per Arne Vollan from comment #3) > I think there might be places where we added constructors, but forgot to add > the !COMPILER_SUPPORTS(NSDMI_FOR_AGGREGATES) compile guard. Should we > attempt to find those instances? We should look for such usage and clean it up. I suggest we do that in another bug/patch.
Per Arne Vollan
Comment 5 2018-04-14 14:03:07 PDT
(In reply to Daniel Bates from comment #4) > (In reply to Per Arne Vollan from comment #3) > > I think there might be places where we added constructors, but forgot to add > > the !COMPILER_SUPPORTS(NSDMI_FOR_AGGREGATES) compile guard. Should we > > attempt to find those instances? > > We should look for such usage and clean it up. I suggest we do that in > another bug/patch. Sounds good!
Daniel Bates
Comment 6 2018-04-20 14:10:59 PDT
Committed r230856: <https://trac.webkit.org/changeset/230856>
Radar WebKit Bug Importer
Comment 7 2018-04-20 14:11:26 PDT
<rdar://problem/39608516>
Note You need to log in before you can comment on or make changes to this bug.