Bug 184543

Summary: [iOS] AirPlay device name is sometimes wrong
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, jer.noble, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch for landing
none
Patch for landing
none
Archive of layout-test-results from ews107 for mac-sierra-wk2
none
Patch for landing
none
Patch for landing
none
Patch for landing
none
Patch for landing
none
Patch for landing none

Eric Carlson
Reported 2018-04-12 09:06:40 PDT
AirPlay device name is sometimes wrong
Attachments
Patch (4.92 KB, patch)
2018-04-12 11:42 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch (5.01 KB, patch)
2018-04-12 11:50 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch (5.08 KB, patch)
2018-04-12 11:54 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch for landing (5.14 KB, patch)
2018-04-12 13:01 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch for landing (5.57 KB, patch)
2018-04-12 13:49 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews107 for mac-sierra-wk2 (4.19 MB, application/zip)
2018-04-12 14:40 PDT, EWS Watchlist 		no flags
Details
Patch for landing (5.60 KB, patch)
2018-04-12 14:48 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch for landing (7.66 KB, patch)
2018-04-16 13:41 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch for landing (7.63 KB, patch)
2018-04-16 13:58 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch for landing (7.97 KB, patch)
2018-04-16 14:40 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch for landing (8.52 KB, patch)
2018-04-17 06:15 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (10) View All Add attachment proposed patch, testcase, etc.
Eric Carlson
Comment 1 2018-04-12 09:07:55 PDT
<rdar://problem/39105498>
Eric Carlson
Comment 2 2018-04-12 11:42:41 PDT
Created attachment 337814 [details] Patch
Jer Noble
Comment 3 2018-04-12 11:45:32 PDT
Comment on attachment 337814 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=337814&action=review > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:2791 > + if ([getAVOutputContextClass() respondsToSelector:@selector(sharedAudioPresentationOutputContext)]) { Nit: should this be below the AVFoundationLibrary() check below?
Eric Carlson
Comment 4 2018-04-12 11:50:44 PDT
Created attachment 337817 [details] Patch Patch for landing
Eric Carlson
Comment 5 2018-04-12 11:54:43 PDT
Created attachment 337818 [details] Patch Patch for landing
Eric Carlson
Comment 6 2018-04-12 13:01:38 PDT
Created attachment 337824 [details] Patch for landing Patch for landing
Eric Carlson
Comment 7 2018-04-12 13:49:33 PDT
Created attachment 337832 [details] Patch for landing Patch for landing
EWS Watchlist
Comment 8 2018-04-12 14:40:01 PDT
Comment on attachment 337832 [details] Patch for landing Attachment 337832 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/7297841 New failing tests: animations/animation-followed-by-transition.html
EWS Watchlist
Comment 9 2018-04-12 14:40:03 PDT
Created attachment 337836 [details] Archive of layout-test-results from ews107 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Eric Carlson
Comment 10 2018-04-12 14:48:23 PDT
Created attachment 337838 [details] Patch for landing Patch for landing
Eric Carlson
Comment 11 2018-04-16 13:41:32 PDT
Created attachment 338033 [details] Patch for landing Patch for landing
Eric Carlson
Comment 12 2018-04-16 13:58:27 PDT
Created attachment 338037 [details] Patch for landing Patch for landing
Eric Carlson
Comment 13 2018-04-16 14:40:14 PDT
Created attachment 338043 [details] Patch for landing Patch for landing
Eric Carlson
Comment 14 2018-04-17 06:15:16 PDT
Created attachment 338103 [details] Patch for landing Patch for landing
WebKit Commit Bot
Comment 15 2018-04-17 07:55:48 PDT
Comment on attachment 338103 [details] Patch for landing Clearing flags on attachment: 338103 Committed r230708: <https://trac.webkit.org/changeset/230708>
WebKit Commit Bot
Comment 16 2018-04-17 07:55:49 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.