| Summary: | [Win][WebKit] Implement InjectedBundleWin.cpp | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Fujii Hironori <Hironori.Fujii> | ||||||||
| Component: | WebKit Misc. | Assignee: | Fujii Hironori <Hironori.Fujii> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | achristensen, annulen, bfulgham, pvollan, rniwa, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 174003 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Fujii Hironori
2018-04-11 19:40:59 PDT
Created attachment 337770 [details]
Patch
Comment on attachment 337770 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=337770&action=review > Source/WebKit/WebProcess/InjectedBundle/win/InjectedBundleWin.cpp:36 > + HMODULE lib = ::LoadLibrary(m_path.charactersWithNullTermination().data()); LoadLibrary needs wchar_t, not UChar, so you should use WTF::stringToNullTerminatedWChar here Created attachment 338076 [details]
Patch
Thank you for the review. Addressed the review feedback.
Comment on attachment 338076 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=338076&action=review > Source/WebKit/WebProcess/InjectedBundle/win/InjectedBundleWin.cpp:45 > + (*proc)(toAPI(this), toAPI(initializationUserData)); You can write it simply as proc(toAPI(this), toAPI(initializationUserData)); Created attachment 338177 [details]
Patch to land
Thank you. Addressed the review feedback.
Committed r230754: <https://trac.webkit.org/changeset/230754> |