Bug 184513

Summary: [WPE] Make WebKitWebViewBackend object mandatory for webkit_web_view_new*() constructors
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, bugs-noreply, cgarcia, ews-watchlist, gns, mcatanzaro, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 184357    
Attachments:
Description Flags
Patch none

Description Zan Dobersek 2018-04-11 12:29:12 PDT
[WPE] Make WebKitWebViewBackend object mandatory for webkit_web_view_new*() constructors
Comment 1 Zan Dobersek 2018-04-11 12:36:21 PDT
Created attachment 337721 [details]
Patch
Comment 2 EWS Watchlist 2018-04-11 12:38:51 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Michael Catanzaro 2018-04-11 14:58:38 PDT
Comment on attachment 337721 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337721&action=review

> Tools/TestWebKitAPI/glib/WebKitGLib/TestMain.h:149
> +            auto* backend = wpe_view_backend_create();
> +            return webkit_web_view_backend_new(backend, reinterpret_cast<GDestroyNotify>(wpe_view_backend_destroy), backend);

I would write it in one line
Comment 4 Zan Dobersek 2018-04-11 22:50:32 PDT
Comment on attachment 337721 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337721&action=review

>> Tools/TestWebKitAPI/glib/WebKitGLib/TestMain.h:149
>> +            return webkit_web_view_backend_new(backend, reinterpret_cast<GDestroyNotify>(wpe_view_backend_destroy), backend);
> 
> I would write it in one line

You can't, because the backend value is passed in as two separate arguments.
Comment 5 Zan Dobersek 2018-04-11 22:53:28 PDT
Comment on attachment 337721 [details]
Patch

Clearing flags on attachment: 337721

Committed r230557: <https://trac.webkit.org/changeset/230557>
Comment 6 Zan Dobersek 2018-04-11 22:53:32 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-04-11 22:54:16 PDT
<rdar://problem/39372308>