Bug 184513 – [WPE] Make WebKitWebViewBackend object mandatory for webkit_web_view_new*() constructors

• Component: New Bugs
• Status: RESOLVED FIXED

[Zan Dobersek]

[WPE] Make WebKitWebViewBackend object mandatory for webkit_web_view_new*() constructors

[Zan Dobersek]

Created attachment 337721 [details]
Patch

[EWS Watchlist]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Michael Catanzaro]

Comment on attachment 337721 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337721&action=review

> Tools/TestWebKitAPI/glib/WebKitGLib/TestMain.h:149
> +            auto* backend = wpe_view_backend_create();
> +            return webkit_web_view_backend_new(backend, reinterpret_cast<GDestroyNotify>(wpe_view_backend_destroy), backend);

I would write it in one line

[Zan Dobersek]

Comment on attachment 337721 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337721&action=review

>> Tools/TestWebKitAPI/glib/WebKitGLib/TestMain.h:149
>> +            return webkit_web_view_backend_new(backend, reinterpret_cast<GDestroyNotify>(wpe_view_backend_destroy), backend);
> 
> I would write it in one line

You can't, because the backend value is passed in as two separate arguments.

[Zan Dobersek]

Comment on attachment 337721 [details]
Patch

Clearing flags on attachment: 337721

Committed r230557: <https://trac.webkit.org/changeset/230557>

[Zan Dobersek]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/39372308>