Bug 184494 – Make WebDriverW3CWebServer inherit from WebPlatformTestServer

• Component: Tools / Tests
• Status: NEW

[Carlos Garcia Campos]

To share the common code instead of duplicating it and avoid future problems when updating WPT layout tests.

[Carlos Garcia Campos]

Created attachment 337695 [details]
Patch

[Carlos Garcia Campos]

Ping youenn.

[youenn fablet]

Will have a look today

[youenn fablet]

Comment on attachment 337695 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337695&action=review

> Tools/Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:42
> +        self._mappings = []

I wonder whether we could not unify a bit more W3C and WPT config.json files.
The first has an ssl config that might be needed to WebDriver at some point.
The other has doc_root but maybe it no longer needs it?

I guess the only difference that might need to remain would be ports if we wanted to have both W3C and WebDriver in parallel.
Maybe we do not even need different port values?

> Tools/Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:45
> +        doc_root = os.path.join(WebKitFinder(self._port_obj.host.filesystem).path_from_webkit_base('WebDriverTests'), 'imported', 'w3c')

We usually use self._port_obj.host.filesystem.join.

> Tools/Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:54
> +            self._port_obj.host.filesystem.remove(temporary_config_file)

Would it be possible to not override the base method here?
Maybe by updating a bit the base method?

> Tools/Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:73
>              time.sleep(sleep_secs)

Maybe this could be the default implementation of __wait_for_server?

[Michael Catanzaro]

Forgot about this?

[Alex Christensen]

Comment on attachment 337695 [details]
Patch

This has been requesting review for more than one year.  If this is still needed, please rebase and re-request review.