Bug 184469

Summary: Layout Test http/wpt/service-workers/header-filtering.https.html is a flaky failure
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: Service WorkersAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch none

Ryan Haddad
Reported 2018-04-10 14:17:56 PDT
The following layout test is flaky on macOS http/wpt/service-workers/header-filtering.https.html Probable cause: This test was added with https://trac.webkit.org/changeset/230365 Flakiness Dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Fwpt%2Fservice-workers%2Fheader-filtering.https.html --- /Volumes/Data/slave/sierra-debug-tests-wk2/build/layout-test-results/http/wpt/service-workers/header-filtering.https-expected.txt +++ /Volumes/Data/slave/sierra-debug-tests-wk2/build/layout-test-results/http/wpt/service-workers/header-filtering.https-actual.txt @@ -1,13 +1,12 @@ - PASS Prepare tests: setup worker and register the client PASS Prepare tests: Add a frame controlled by service worker -PASS Test same-origin fetch +FAIL Test same-origin fetch assert_array_equals: lengths differ, expected 15 got 3 FAIL Test cors cross-origin fetch assert_array_equals: lengths differ, expected 13 got 15 FAIL Test no-cors cross-origin fetch assert_array_equals: lengths differ, expected 13 got 15 -PASS Test same-origin script load +FAIL Test same-origin script load assert_array_equals: lengths differ, expected 13 got 15 PASS Test no-cors script load PASS Test cors script load -FAIL Test HTML load assert_array_equals: lengths differ, expected 13 got 17 +PASS Test HTML load PASS After tests clean-up
Attachments
Patch (2.96 KB, patch)
2018-04-27 12:47 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.97 KB, patch)
2018-05-02 12:18 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (1.43 KB, patch)
2018-05-18 10:23 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-04-13 16:47:31 PDT
<rdar://problem/39428226>
Ryan Haddad
Comment 2 2018-04-13 17:41:10 PDT
Marked test as flaky in https://trac.webkit.org/r230651
youenn fablet
Comment 3 2018-04-27 12:47:31 PDT
Created attachment 339015 [details] Patch
Chris Dumez
Comment 4 2018-05-02 12:11:34 PDT
Comment on attachment 339015 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=339015&action=review > LayoutTests/ChangeLog:9 > + Ensure that the message posted for the loading of the initial iframe is actuall received before doing further tests. typo: actuall
youenn fablet
Comment 5 2018-05-02 12:18:50 PDT
Created attachment 339323 [details] Patch for landing
WebKit Commit Bot
Comment 6 2018-05-02 12:53:45 PDT
Comment on attachment 339323 [details] Patch for landing Clearing flags on attachment: 339323 Committed r231255: <https://trac.webkit.org/changeset/231255>
WebKit Commit Bot
Comment 7 2018-05-02 12:53:47 PDT
All reviewed patches have been landed. Closing bug.
youenn fablet
Comment 8 2018-05-18 10:21:43 PDT
https://trac.webkit.org/changeset/231287/webkit seems to have accidentally made test flaky again, will fix it.
youenn fablet
Comment 9 2018-05-18 10:23:16 PDT
Reopening to attach new patch.
youenn fablet
Comment 10 2018-05-18 10:23:16 PDT
Created attachment 340709 [details] Patch
WebKit Commit Bot
Comment 11 2018-05-18 10:59:00 PDT
Comment on attachment 340709 [details] Patch Clearing flags on attachment: 340709 Committed r231965: <https://trac.webkit.org/changeset/231965>
WebKit Commit Bot
Comment 12 2018-05-18 10:59:01 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.