Bug 184451

Summary: Deactivate the WindowServer connection for the WebContent process.
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebKit Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, bfulgham, cdumez, cmarcelo, commit-queue, darin, dbates, ews-watchlist, sabouhallawa, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 184633    
Bug Blocks: 184484, 190056    
Attachments:
Description Flags
Patch
commit-queue: commit-queue-
Patch none

Per Arne Vollan
Reported 2018-04-10 09:10:11 PDT
Defining ENABLE_WEBPROCESS_WINDOWSERVER_BLOCKING as 1 will deactivate the WindowServer connection for the WebContent process.
Attachments
Patch (1.51 KB, patch)
2018-04-10 09:17 PDT, Per Arne Vollan 		commit-queue: commit-queue-
DetailsFormatted DiffDiff
Patch (1.54 KB, patch)
2018-04-14 10:19 PDT, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Per Arne Vollan
Comment 1 2018-04-10 09:10:45 PDT
<rdar://problem/38313938>
Per Arne Vollan
Comment 2 2018-04-10 09:17:33 PDT
Created attachment 337612 [details] Patch
Brent Fulgham
Comment 3 2018-04-10 21:24:58 PDT
Comment on attachment 337612 [details] Patch r=me, but don't land until the build bots are ready.
Per Arne Vollan
Comment 4 2018-04-11 07:02:54 PDT
Comment on attachment 337612 [details] Patch Thanks for reviewing!
WebKit Commit Bot
Comment 5 2018-04-11 07:29:45 PDT
Comment on attachment 337612 [details] Patch Clearing flags on attachment: 337612 Committed r230523: <https://trac.webkit.org/changeset/230523>
WebKit Commit Bot
Comment 6 2018-04-11 07:29:46 PDT
All reviewed patches have been landed. Closing bug.
Said Abou-Hallawa
Comment 7 2018-04-11 18:09:17 PDT
Reverted r230523 for reason: Introduced MotionMark regression Committed r230552: <https://trac.webkit.org/changeset/230552>
Per Arne Vollan
Comment 8 2018-04-14 10:13:55 PDT
Comment on attachment 337612 [details] Patch I am not able to reproduce the MotionMark regression now.
WebKit Commit Bot
Comment 9 2018-04-14 10:15:13 PDT
Comment on attachment 337612 [details] Patch Rejecting attachment 337612 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 337612, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WTF/ChangeLog contains OOPS!. Full output: http://webkit-queues.webkit.org/results/7316375
Per Arne Vollan
Comment 10 2018-04-14 10:19:39 PDT
Created attachment 337960 [details] Patch
WebKit Commit Bot
Comment 11 2018-04-14 10:57:58 PDT
Comment on attachment 337960 [details] Patch Clearing flags on attachment: 337960 Committed r230659: <https://trac.webkit.org/changeset/230659>
WebKit Commit Bot
Comment 12 2018-04-14 10:58:00 PDT
All reviewed patches have been landed. Closing bug.
WebKit Commit Bot
Comment 13 2018-04-14 18:40:16 PDT
Re-opened since this is blocked by bug 184633
Alexey Proskuryakov
Comment 14 2018-04-14 18:41:10 PDT
> r=me, but don't land until the build bots are ready. What Brent said. Rolling back now.
Brent Fulgham
Comment 15 2018-04-16 12:00:55 PDT
(In reply to Alexey Proskuryakov from comment #14) > > r=me, but don't land until the build bots are ready. > > What Brent said. Rolling back now. This should be okay to land now. The performance bots are now running the fixed QuartzCore, so this should be safe.
Brent Fulgham
Comment 16 2018-04-16 12:01:35 PDT
(In reply to Brent Fulgham from comment #15) > (In reply to Alexey Proskuryakov from comment #14) > > > r=me, but don't land until the build bots are ready. > > > > What Brent said. Rolling back now. > > This should be okay to land now. The performance bots are now running the > fixed QuartzCore, so this should be safe. ... and this does not introduce any build or test correctness issues.
WebKit Commit Bot
Comment 17 2018-04-16 12:20:22 PDT
Comment on attachment 337960 [details] Patch Clearing flags on attachment: 337960 Committed r230677: <https://trac.webkit.org/changeset/230677>
WebKit Commit Bot
Comment 18 2018-04-16 12:20:24 PDT
All reviewed patches have been landed. Closing bug.
Darin Adler
Comment 19 2018-04-16 17:50:44 PDT
Comment on attachment 337960 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=337960&action=review > Source/WTF/wtf/FeatureDefines.h:241 > +#define ENABLE_WEBPROCESS_WINDOWSERVER_BLOCKING __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400 Are you sure this pattern works? I seem to recall that this form does not work correctly. I think it needs to be more like: #if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400 #define ENABLE_WEBPROCESS_WINDOWSERVER_BLOCKING 1 #else #define ENABLE_WEBPROCESS_WINDOWSERVER_BLOCKING 0 #endif
Per Arne Vollan
Comment 20 2018-04-16 18:44:09 PDT
(In reply to Darin Adler from comment #19) > Comment on attachment 337960 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=337960&action=review > > > Source/WTF/wtf/FeatureDefines.h:241 > > +#define ENABLE_WEBPROCESS_WINDOWSERVER_BLOCKING __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400 > > Are you sure this pattern works? I seem to recall that this form does not > work correctly. I think it needs to be more like: > > #if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400 > #define ENABLE_WEBPROCESS_WINDOWSERVER_BLOCKING 1 > #else > #define ENABLE_WEBPROCESS_WINDOWSERVER_BLOCKING 0 > #endif I believe it works since I have tested this by building for several macOS versions. However, I will double-check.
Per Arne Vollan
Comment 21 2018-04-19 11:28:09 PDT
Reverted r230677 for reason: Introduced Netflix problems. Committed r230811: <https://trac.webkit.org/changeset/230811>
WebKit Commit Bot
Comment 22 2018-04-23 15:41:40 PDT
Comment on attachment 337960 [details] Patch Clearing flags on attachment: 337960 Committed r230930: <https://trac.webkit.org/changeset/230930>
WebKit Commit Bot
Comment 23 2018-04-23 15:41:42 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.