Bug 184450

Summary: [GLIB] Handle strings containing null characters
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, mcatanzaro, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: Gtk, InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch mcatanzaro: review+

Carlos Garcia Campos
Reported 2018-04-10 08:59:12 PDT
We should be able to evaluate scripts containing null characters and to handle strings that contains them too. In JavaScript strings are not null-terminated, they can contain null characters.
Attachments
Patch (75.70 KB, patch)
2018-04-10 09:07 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Patch (75.71 KB, patch)
2018-04-11 00:19 PDT, Carlos Garcia Campos 		mcatanzaro: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2018-04-10 09:07:19 PDT
Created attachment 337608 [details] Patch
Michael Catanzaro
Comment 2 2018-04-10 10:56:21 PDT
Comment on attachment 337608 [details] Patch EWS are all red
Carlos Garcia Campos
Comment 3 2018-04-11 00:19:21 PDT
Created attachment 337683 [details] Patch
Michael Catanzaro
Comment 4 2018-04-11 10:59:50 PDT
Comment on attachment 337683 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=337683&action=review > Source/JavaScriptCore/API/glib/JSCContext.cpp:670 > + * @length: length of @code, or -1 if @code is a nul-terminated string I think we usually write "null-terminated."
Carlos Garcia Campos
Comment 5 2018-04-11 23:59:51 PDT
Committed r230558: <https://trac.webkit.org/changeset/230558>
Radar WebKit Bug Importer
Comment 6 2018-04-12 00:00:39 PDT
<rdar://problem/39373359>
Note You need to log in before you can comment on or make changes to this bug.