Bug 184449

Summary:

Support negative sw/sh values in createImageBitmap().

Product:

WebKit

Reporter:

Ms2ger (he/him; ⌚ UTC+1/+2) <Ms2ger>

Component:

Canvas

Assignee:

Ms2ger (he/him; ⌚ UTC+1/+2) <Ms2ger>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, commit-queue, dino, esprehn+autocc, ews-watchlist, gyuyoung.kim, rniwa, sam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

182424

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews103 for mac-sierra	none
Archive of layout-test-results from ews106 for mac-sierra-wk2	none
Archive of layout-test-results from ews121 for ios-simulator-wk2	none
Archive of layout-test-results from ews115 for mac-sierra	none
Archive of layout-test-results from ews206 for win-future	none
Patch	none
Patch	none

Ms2ger (he/him; ⌚ UTC+1/+2)

Reported 2018-04-10 07:53:49 PDT

Attachments
Patch (9.99 KB, patch) 2018-04-10 08:03 PDT, Ms2ger (he/him; ⌚ UTC+1/+2)	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews103 for mac-sierra (2.23 MB, application/zip) 2018-04-10 09:08 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews106 for mac-sierra-wk2 (3.04 MB, application/zip) 2018-04-10 09:15 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews121 for ios-simulator-wk2 (2.46 MB, application/zip) 2018-04-10 09:35 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews115 for mac-sierra (2.97 MB, application/zip) 2018-04-10 09:42 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews206 for win-future (13.14 MB, application/zip) 2018-04-10 10:01 PDT, EWS Watchlist	no flags	Details
Patch (14.69 KB, patch) 2018-04-12 03:37 PDT, Ms2ger (he/him; ⌚ UTC+1/+2)	no flags	Details Formatted Diff Diff
Patch (14.67 KB, patch) 2018-04-25 05:17 PDT, Ms2ger (he/him; ⌚ UTC+1/+2)	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Ms2ger (he/him; ⌚ UTC+1/+2)

Comment 1 2018-04-10 08:03:07 PDT

Created attachment 337605 [details] Patch

EWS Watchlist

Comment 2 2018-04-10 09:08:46 PDT

Comment on attachment 337605 [details] Patch Attachment 337605 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/7268573 New failing tests: imported/w3c/web-platform-tests/workers/name-property.html http/wpt/2dcontext/imagebitmap/createImageBitmap.html

EWS Watchlist

Comment 3 2018-04-10 09:08:47 PDT

Created attachment 337609 [details] Archive of layout-test-results from ews103 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 4 2018-04-10 09:15:52 PDT

Comment on attachment 337605 [details] Patch Attachment 337605 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/7268620 New failing tests: http/wpt/2dcontext/imagebitmap/createImageBitmap.html

EWS Watchlist

Comment 5 2018-04-10 09:15:54 PDT

Created attachment 337611 [details] Archive of layout-test-results from ews106 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 6 2018-04-10 09:35:28 PDT

Comment on attachment 337605 [details] Patch Attachment 337605 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/7268627 New failing tests: http/wpt/2dcontext/imagebitmap/createImageBitmap.html

EWS Watchlist

Comment 7 2018-04-10 09:35:30 PDT

Created attachment 337613 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4

EWS Watchlist

Comment 8 2018-04-10 09:42:44 PDT

Comment on attachment 337605 [details] Patch Attachment 337605 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/7268686 New failing tests: http/wpt/2dcontext/imagebitmap/createImageBitmap.html

EWS Watchlist

Comment 9 2018-04-10 09:42:46 PDT

Created attachment 337614 [details] Archive of layout-test-results from ews115 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 10 2018-04-10 10:01:27 PDT

Comment on attachment 337605 [details] Patch Attachment 337605 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/7268850 New failing tests: http/wpt/2dcontext/imagebitmap/createImageBitmap.html

EWS Watchlist

Comment 11 2018-04-10 10:01:39 PDT

Created attachment 337616 [details] Archive of layout-test-results from ews206 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews206 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

Ms2ger (he/him; ⌚ UTC+1/+2)

Comment 12 2018-04-12 03:37:43 PDT

Created attachment 337785 [details] Patch

Ms2ger (he/him; ⌚ UTC+1/+2)

Comment 13 2018-04-25 05:17:11 PDT

Created attachment 338721 [details] Patch

WebKit Commit Bot

Comment 14 2018-05-07 10:20:47 PDT

Comment on attachment 338721 [details] Patch Clearing flags on attachment: 338721 Committed r231440: <https://trac.webkit.org/changeset/231440>

WebKit Commit Bot

Comment 15 2018-05-07 10:20:48 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 16 2018-05-07 10:22:26 PDT

<rdar://problem/40026929>

Note You need to log in before you can comment on or make changes to this bug.