Bug 184399

Summary: [GTK] Miscellaneous build cleanups
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: WebKitGTKAssignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, ews-watchlist, mcatanzaro, zan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews206 for win-future
none
Patch zan: review+

Michael Catanzaro
Reported 2018-04-08 09:18:02 PDT
Miscellaneous build cleanups * Remove a bunch of unused stuff * No need to define variables pointing to pkg-config files in OptionsGTK.cmake
Attachments
Patch (6.09 KB, patch)
2018-04-08 09:19 PDT, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews206 for win-future (12.18 MB, application/zip)
2018-04-08 11:31 PDT, EWS Watchlist 		no flags
Details
Patch (4.80 KB, patch)
2018-04-08 20:43 PDT, Michael Catanzaro 		zan: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2018-04-08 09:19:41 PDT
Created attachment 337459 [details] Patch
EWS Watchlist
Comment 2 2018-04-08 11:31:07 PDT
Comment on attachment 337459 [details] Patch Attachment 337459 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/7246072 New failing tests: http/tests/security/canvas-remote-read-remote-video-localhost.html
EWS Watchlist
Comment 3 2018-04-08 11:31:18 PDT
Created attachment 337461 [details] Archive of layout-test-results from ews206 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews206 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Michael Catanzaro
Comment 4 2018-04-08 20:20:04 PDT
Well it breaks gtk-doc, but I have no idea why.
Michael Catanzaro
Comment 5 2018-04-08 20:41:41 PDT
(In reply to Michael Catanzaro from comment #4) > Well it breaks gtk-doc, but I have no idea why. Removed too much.
Michael Catanzaro
Comment 6 2018-04-08 20:43:35 PDT
Created attachment 337477 [details] Patch
Michael Catanzaro
Comment 7 2018-04-25 09:23:11 PDT
Committed r230996: <https://trac.webkit.org/changeset/230996>
Note You need to log in before you can comment on or make changes to this bug.