Bug 184383 – [WPE] Add some missing jhbuild dependencies

• Component: WPE WebKit
• Status: RESOLVED FIXED

[Charlie Turner]

[WPE] Add some missing jhbuild dependencies on Fedora

[Charlie Turner]

Created attachment 337420 [details]
Patch

[Charlie Turner]

Created attachment 337421 [details]
Patch

[Charlie Turner]

Created attachment 337422 [details]
Patch

[Michael Catanzaro]

Comment on attachment 337422 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337422&action=review

Please make some attempt to update Debian and Arch as well

> Tools/wpe/install-dependencies:294
> +        libXrandr-devel \

xorg-xrandr for Arch, libxrandr-dev for Debian

> Tools/wpe/install-dependencies:299
> +        mesa-libEGL-devel \

libegl1-mesa-dev for Debian. I guess in Arch it's just included in mesa

> Tools/wpe/install-dependencies:305
> +        yasm"

yasm in all three distros.

[Adrian Perez]

(In reply to Michael Catanzaro from comment #4)
> Comment on attachment 337422 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=337422&action=review
> 
> Please make some attempt to update Debian and Arch as well
> 
> > Tools/wpe/install-dependencies:294
> > +        libXrandr-devel \
> 
> xorg-xrandr for Arch, libxrandr-dev for Debian
>
> > Tools/wpe/install-dependencies:299
> > +        mesa-libEGL-devel \
> 
> libegl1-mesa-dev for Debian. I guess in Arch it's just included in mesa

Yes, I can confirm this. In Arch there are no “*-devel” packages; the
“normal” package includes also the files needed for development.

[Charlie Turner]

Created attachment 337488 [details]
Patch

[Adrian Perez]

Comment on attachment 337488 [details]
Patch

Informal r+ here :-)

Works fine on Arch Linux with the patch applied (I actually tested), and
the Debian/Fedora parts of the changes LGTM as well (I am not very familiar
with Fedora, though).

[Michael Catanzaro]

Comment on attachment 337488 [details]
Patch

JHBuild will always be a best-effort, works-for-me thing... we'll just make it as reliable as we can.

[WebKit Commit Bot]

Comment on attachment 337488 [details]
Patch

Rejecting attachment 337488 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 337488, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Tools/ChangeLog contains OOPS!.

Full output: http://webkit-queues.webkit.org/results/7256352

[Michael Catanzaro]

(In reply to WebKit Commit Bot from comment #9)
> ChangeLog entry in Tools/ChangeLog contains OOPS!

[Carlos Alberto Lopez Perez]

(In reply to Michael Catanzaro from comment #10)
> (In reply to WebKit Commit Bot from comment #9)
> > ChangeLog entry in Tools/ChangeLog contains OOPS!

and what is wrong with that? didn't you gave an r+ with the cq+?

[Michael Catanzaro]

Comment on attachment 337488 [details]
Patch

Um, nope, because there was no r?. Trying again.

[WebKit Commit Bot]

Comment on attachment 337488 [details]
Patch

Clearing flags on attachment: 337488

Committed r230460: <https://trac.webkit.org/changeset/230460>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.