Summary: | REGRESSION(r229929): localStorage is broken for WebInspector | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||||||||||
Component: | DOM | Assignee: | Sihui Liu <sihui_liu> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | bburg, cdumez, commit-queue, dbates, ews-watchlist, joepeck, rniwa, sihui_liu, webkit-bug-importer | ||||||||||||
Priority: | P1 | Keywords: | InRadar, Regression | ||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Bug Depends on: | 69138 | ||||||||||||||
Bug Blocks: | |||||||||||||||
Attachments: |
|
Description
Devin Rousso
2018-04-06 23:02:12 PDT
Created attachment 337439 [details]
Patch
Comment on attachment 337439 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=337439&action=review > Source/WebCore/ChangeLog:15 > + No new tests, removed an insufficient judgement to fix regression. Is it not possible to write a test for this? Created attachment 337453 [details]
Patch
When is the error ever cleared? If there was an error before entering this method would it have been cleared? (In reply to Joseph Pecoraro from comment #5) > When is the error ever cleared? If there was an error before entering this > method would it have been cleared? From the doc [1]: """ If the most recent sqlite3_* API call associated with database connection D failed, then the sqlite3_errcode(D) interface returns the numeric result code or extended result code for that API call. If the most recent API call was successful, then the return value from sqlite3_errcode() is undefined. """ So my understanding is: - If the call to sqlite3_column_blob() failed, sqlite3_errcode() will return a valid error code. - If the call to sqlite3_column_blob() succeeded, sqlite3_errcode() may return whatever. Unfortunately, it does not look like there is a good way to check if the call to sqlite3_column_blob() failed. This is because as per [2] sqlite3_column_blob() can return NULL due to: - An error - The blob has zero length [1] https://www.sqlite.org/c3ref/errcode.html [2] https://www.sqlite.org/c3ref/column_blob.html Comment on attachment 337453 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=337453&action=review > Source/WebCore/platform/sql/SQLiteStatement.cpp:388 > + if (!(error == SQLITE_OK || error == SQLITE_ROW || error == SQLITE_DONE)) As per the doc, "If the most recent API call was successful, then the return value from sqlite3_errcode() is undefined." Therefore, I do not think this patch is correct. Created attachment 337507 [details]
Patch
Created attachment 337510 [details]
Patch
Comment on attachment 337510 [details] Patch Attachment 337510 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/7255578 New failing tests: imported/w3c/web-platform-tests/workers/name-property.html Created attachment 337518 [details]
Archive of layout-test-results from ews101 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 337510 [details]
Patch
failure is unrelated.
Comment on attachment 337510 [details] Patch Clearing flags on attachment: 337510 Committed r230456: <https://trac.webkit.org/changeset/230456> All reviewed patches have been landed. Closing bug. |