Bug 184374 – Pass FetchOptions and SecurityOrigin as load parameters from WebProcess to NetworkProcess

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[youenn fablet]

Pass FetchOptions and SecurityOrigin as load parameters from WebProcess to NetworkProcess

[youenn fablet]

Created attachment 337404 [details]
Patch

[Chris Dumez]

Comment on attachment 337404 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337404&action=review

Looks good overall but I have one concern.

> Source/WebKit/NetworkProcess/NetworkResourceLoadParameters.cpp:91
> +        encoder << sourceOrigin->enforcesFilePathSeparation();

Why are we doing this here instead of introducing a (reusable) encoder / decoder for SecurityOrigin class? This looks like a lot of code here for SecurityOrigin internals.

[youenn fablet]

(In reply to Chris Dumez from comment #2)
> Comment on attachment 337404 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=337404&action=review
> 
> Looks good overall but I have one concern.
> 
> > Source/WebKit/NetworkProcess/NetworkResourceLoadParameters.cpp:91
> > +        encoder << sourceOrigin->enforcesFilePathSeparation();
> 
> Why are we doing this here instead of introducing a (reusable) encoder /
> decoder for SecurityOrigin class? This looks like a lot of code here for
> SecurityOrigin internals.

The reason is that this currently does not serialize every SecurityOrigin bit, some being only needed for StorageProcess for instance.

I will try to update SecurityOrigin to serialize every bit and add the encoder/decoder in SecurityOrigin.h/.cpp directly.

[youenn fablet]

Created attachment 337656 [details]
Patch

[youenn fablet]

Created attachment 337657 [details]
Patch

[youenn fablet]

Created attachment 337658 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 337658 [details]
Patch

Rejecting attachment 337658 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 337658, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
ce/WebKit/NetworkProcess/NetworkResourceLoader.cpp
Hunk #1 succeeded at 472 (offset 1 line).
patching file Source/WebKit/NetworkProcess/PingLoad.cpp
patching file Source/WebKit/NetworkProcess/PingLoad.h
patching file Source/WebKit/WebProcess/InjectedBundle/InjectedBundle.cpp
patching file Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Chris Dumez']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/7285010

[youenn fablet]

Created attachment 337717 [details]
Rebased

[WebKit Commit Bot]

Comment on attachment 337717 [details]
Rebased

Clearing flags on attachment: 337717

Committed r230541: <https://trac.webkit.org/changeset/230541>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/39356170>