Bug 184358

Summary: Adopt non-deprecated CGColorSpace API
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: Layout and RenderingAssignee: Kate Cheney <katherine_cheney>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, darin, katherine_cheney, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Brent Fulgham
Reported 2018-04-06 08:39:14 PDT
We are using a deprecated CGColorSpace creation method: #pragma clang diagnostic push #pragma clang diagnostic ignored "-Wdeprecated-declarations" cgColorSpace = adoptCF(CGColorSpaceCreateWithICCProfile(colorSpaceData.get())); #pragma clang diagnostic pop We should adopt the newer API (I think this is CGColorSpaceCreateICCBased)
Attachments
Patch (3.17 KB, patch)
2019-08-07 16:11 PDT, Kate Cheney 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-04-06 09:17:51 PDT
<rdar://problem/39239671>
Kate Cheney
Comment 2 2019-08-07 16:11:41 PDT
Created attachment 375762 [details] Patch
WebKit Commit Bot
Comment 3 2019-08-07 16:52:26 PDT
Comment on attachment 375762 [details] Patch Clearing flags on attachment: 375762 Committed r248396: <https://trac.webkit.org/changeset/248396>
WebKit Commit Bot
Comment 4 2019-08-07 16:52:28 PDT
All reviewed patches have been landed. Closing bug.
Simon Fraser (smfr)
Comment 5 2019-08-07 17:02:18 PDT
Yay first bug!
Note You need to log in before you can comment on or make changes to this bug.