Bug 184320
| Summary: | WebCore::LocalDefaultSystemAppearance talks to NSApp | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> |
| Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | bfulgham, pvollan, timothy, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=184322 | ||
Brent Fulgham
WebCore::LocalDefaultSystemAppearance talks to NSApp to get information about the current system appearance (colors, fonts, etc.). This code path is getting hit while computing styles in the WebContent process.
It would be nice if we could either broker these calls to the UIProcess, or perhaps cache these values on the WebProcess side, updating when user settings change.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/39193372>
Timothy Hatcher
We do cache the system colors, for each color, when it is not in the cache yet. The cache is cleared when the user appearance settings change.
https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/rendering/RenderThemeMac.mm#L453