Bug 184292
| Summary: | [GTK] Undefined Behavior / crash in WebRtcVideoChannel::WebRtcVideoChannel() with null encoder_factory | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ms2ger (he/him; ⌚ UTC+1/+2) <Ms2ger> |
| Component: | WebRTC | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | alex, bugs-noreply, calvaris, tsaunier, youennf |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ms2ger (he/him; ⌚ UTC+1/+2)
If encoder_factory_ is null, AssignPayloadTypesAndDefaultCodecs() returns an empty vector, MapCodecs takes the empty vector, asserts in debug builds, and returns a new empty vector in release builds, and then we call front() unconditionally, which is Undefined Behavior for an empty vector.
This appears to cause a crash in fast/mediastream/RTCPeerConnection-addIceCandidate.html.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Alejandro G. Castro
Thanks for reporting. WebRTC support for GTK port is still not complete, we are still pushing code upstream which would include enabling all the mediastream tests, we are currently working on it. We can leave this bug open to keep this issue in mind for the moment we have everything in place.
Xabier Rodríguez Calvar
Usecase?