Bug 184289

Summary: Fix the print formatter build
Product: WebKit Reporter: Beth Dakin <bdakin>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, jer.noble, mitz, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
mitz: review-
Patch that addresses Dan's comments
none
Patch, rebased
none
Patch, rebased mitz: review+

Beth Dakin
Reported 2018-04-03 21:29:07 PDT
Fix the print formatter build rdar://problem/39164641
Attachments
Patch (5.72 KB, patch)
2018-04-03 21:31 PDT, Beth Dakin 		mitz: review-
DetailsFormatted DiffDiff
Patch that addresses Dan's comments (5.03 KB, patch)
2018-04-04 10:05 PDT, Beth Dakin 		no flags
DetailsFormatted DiffDiff
Patch, rebased (5.08 KB, patch)
2018-04-04 10:46 PDT, Beth Dakin 		no flags
DetailsFormatted DiffDiff
Patch, rebased (5.03 KB, patch)
2018-04-04 11:07 PDT, Beth Dakin 		mitz: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Beth Dakin
Comment 1 2018-04-03 21:31:22 PDT
Created attachment 337143 [details] Patch
mitz
Comment 2 2018-04-03 21:44:10 PDT
Comment on attachment 337143 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=337143&action=review > Source/WebKit/UIProcess/_WKWebViewPrintFormatter.h:37 > +#if ENABLE(MINIMAL_SIMULATOR) > +UIViewPrintFormatter > +#else We don’t use our internal ENABLE() macro in modern WebKit SPI headers. > Source/WebKit/UIProcess/_WKWebViewPrintFormatter.h:41 > +#if !ENABLE(MINIMAL_SIMULATOR) Ditto.
Beth Dakin
Comment 3 2018-04-04 10:05:17 PDT
Created attachment 337182 [details] Patch that addresses Dan's comments
Beth Dakin
Comment 4 2018-04-04 10:46:48 PDT
Created attachment 337189 [details] Patch, rebased
Beth Dakin
Comment 5 2018-04-04 11:07:30 PDT
Created attachment 337194 [details] Patch, rebased
Beth Dakin
Comment 6 2018-04-04 11:29:21 PDT
Thanks Dan! https://trac.webkit.org/changeset/230268/webkit
Radar WebKit Bug Importer
Comment 7 2018-04-04 11:30:22 PDT
<rdar://problem/39181570>
Note You need to log in before you can comment on or make changes to this bug.