Bug 184286

Summary:

[iOS] Rename WKPDFView to WKLegacyPDFView

Product:

WebKit

Reporter:

Andy Estes <aestes>

Component:

New Bugs

Assignee:

Andy Estes <aestes>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin, commit-queue, dino, ews-watchlist, thorton, timothy, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews206 for win-future	none
Patch	aestes: commit-queue-

Andy Estes

Reported 2018-04-03 19:49:10 PDT

[iOS] Rename WKPDFView to WKLegacyPDFView

Attachments
Patch (78.33 KB, patch) 2018-04-03 19:51 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews206 for win-future (12.15 MB, application/zip) 2018-04-03 23:45 PDT, EWS Watchlist	no flags	Details
Patch (78.42 KB, patch) 2018-04-04 09:33 PDT, Andy Estes	aestes: commit-queue-	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Andy Estes

Comment 1 2018-04-03 19:51:52 PDT Comment hidden (obsolete)

Created attachment 337140 [details] Patch

EWS Watchlist

Comment 2 2018-04-03 19:57:42 PDT Comment hidden (obsolete)

Attachment 337140 [details] did not pass style-queue: ERROR: Source/WebKit/UIProcess/ios/WKLegacyPDFView.mm:487: The parameter name "url" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.

Wenson Hsieh

Comment 3 2018-04-03 22:26:23 PDT

Comment on attachment 337140 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=337140&action=review rs=me > Source/WebKit/ChangeLog:7 > + I think it would be nice to have a sentence here describing the ulterior motive.

EWS Watchlist

Comment 4 2018-04-03 23:45:48 PDT Comment hidden (obsolete)

Comment on attachment 337140 [details] Patch Attachment 337140 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/7200925 New failing tests: http/tests/security/local-video-source-from-remote.html

EWS Watchlist

Comment 5 2018-04-03 23:45:58 PDT Comment hidden (obsolete)

Created attachment 337151 [details] Archive of layout-test-results from ews206 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews206 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

Andy Estes

Comment 6 2018-04-04 09:33:11 PDT

Created attachment 337180 [details] Patch

Andy Estes

Comment 7 2018-04-04 10:16:17 PDT

Committed r230261: <https://trac.webkit.org/changeset/230261>

Radar WebKit Bug Importer

Comment 8 2018-04-04 10:18:10 PDT

<rdar://problem/39178317>

Note You need to log in before you can comment on or make changes to this bug.