Summary: | Typed array constructor behaves differently when length is not passed or when undefined is passed | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Koby <koby.b> | ||||||
Component: | JavaScriptCore | Assignee: | James Darpinian <jdarpinian> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | dino, ews-watchlist, fpizlo, jdarpinian, kbr, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | Safari 11 | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 209518 | ||||||||
Attachments: |
|
Description
Koby
2018-04-02 05:28:56 PDT
Also, if you think that my suggested fix in constructGenericTypedArrayView is OK, I'll be happy to send a patch. Thanks for the investigation, I think you are right about the fix. This is causing some WebGL conformance tests to fail so I will make a patch. Created attachment 401806 [details]
Patch
Comment on attachment 401806 [details]
Patch
Nice, can you add a test in `JSTests/stress/`?
And let's wait for EWS results. If it affects on WebGL conformance tests, it is possible that these tests in LayoutTests start showing "PASS" or something. In that case, this patch needs to update -expect files too. Seems that it is not used in LayoutTests for now. So, adding a test to JSTests/stress/ and that's all :) Comment on attachment 401806 [details]
Patch
The patch looks good. Can you add a test to JSTests/stress?
Created attachment 402364 [details]
add test
Comment on attachment 402364 [details]
add test
r=me
Committed r263315: <https://trac.webkit.org/changeset/263315> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402364 [details]. |