Bug 18418

Summary:

REGRESSION (r31736?): DOM tree disappears when navigating to a new page with the Inspector open

Product:

WebKit

Reporter:

Adam Roben (:aroben) <aroben>

Component:

Web Inspector (Deprecated)

Assignee:

Timothy Hatcher <timothy>

Status:

RESOLVED FIXED

Severity:

Major

CC:

timothy

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	aroben: review+

Description Adam Roben (:aroben) 2008-04-10 17:08:12 PDT

The Inspector's DOM tree disappears when you navigate to a new page with the Inspector open.

1. Go to http://webkit.org/
2. Right-click and choose Inspect Element
3. Go to http://www.google.com/

Comment 1 Timothy Hatcher 2008-04-11 12:10:13 PDT

Created attachment 20484 [details]
Patch

Comment 2 Adam Roben (:aroben) 2008-04-11 12:13:24 PDT

Comment on attachment 20484 [details]
Patch

@@ -141,8 +169,7 @@ WebInspector.ElementsPanel.prototype = {
             this.focusedDOMNode = canidateFocusNode;
             if (this.treeOutline.selectedTreeElement)
                 this.treeOutline.selectedTreeElement.expand();
-        } else
-            this.focusedDOMNode = null;
+        }
     },

What's this change for? You don't mention it in the ChangeLog.

Maybe we should file a bug about the event listener being called with the inspected page's global object?

r=me

Comment 3 Timothy Hatcher 2008-04-11 13:00:23 PDT

I moved this.focusedDOMNode = null to the top of the reset function.

Comment 4 Timothy Hatcher 2008-04-11 13:00:34 PDT

Landed in r31815.