Summary: | Layout Test http/tests/websocket/tests/hybi/websocket-cookie-overwrite-behavior.html is a flaky failure | ||
---|---|---|---|
Product: | WebKit | Reporter: | Ryan Haddad <ryanhaddad> |
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> |
Status: | NEW --- | ||
Severity: | Normal | CC: | ap, bfulgham, dbates, webkit-bug-importer |
Priority: | P2 | Keywords: | InRadar |
Version: | WebKit Nightly Build | ||
Hardware: | Unspecified | ||
OS: | Unspecified |
Description
Ryan Haddad
2018-03-29 20:45:51 PDT
This is a new test added with https://trac.webkit.org/changeset/230052/webkit Dan, would you please take a look? <https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fwebsocket%2Ftests%2Fhybi%2Fwebsocket-cookie-overwrite-behavior.html> does not seem to be showing me the results when the test fails whenever I click on a red box and click the link of the form "Show results for WebKit rX" from the popup menu :/ Is this test still flaky. Looking at <https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fwebsocket%2Ftests%2Fhybi%2Fwebsocket-cookie-overwrite-behavior.html> it seems to be consistently passing since r230290 (04/04/2018) on both High Sierra Debug WK1/WK2. It doesn't seem to be flaky on he bots. However, the circumstances are very suspicious, and I doubt that there was an actual progression. This test was very flaky on slow bots, failing ~50% on the time. On some bots, the test abruptly ceased to be flaky around r230292. On others, it ceased to fail around r230210...230235. One suspicious thing is that the progression point are different; another is that there isn't anything there that looks like it could fix it. There were many loader refactorings around this time. Does this test even fail in ToT if the code change in r230052 is reverted? |