Bug 184168

Summary: Remove WTF_EXPORT_STRING_API
Product: WebKit Reporter: JF Bastien <jfbastien>
Component: Web Template FrameworkAssignee: JF Bastien <jfbastien>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, benjamin, cdumez, cmarcelo, commit-queue, dbates, ews-watchlist, jfbastien, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 184164    
Attachments:
Description Flags
patch none

JF Bastien
Reported 2018-03-29 18:40:22 PDT
Remove WTF_EXPORT_STRING_API as requested by a FIXME, and use WTF_EXPORT_PRIVATE instead.
Attachments
patch (51.74 KB, patch)
2018-03-29 18:42 PDT, JF Bastien 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-03-29 18:40:46 PDT
<rdar://problem/39023253>
JF Bastien
Comment 2 2018-03-29 18:42:19 PDT
Created attachment 336830 [details] patch
JF Bastien
Comment 3 2018-03-29 18:52:35 PDT
Forgot to say, I did this with: git grep WTF_EXPORT_STRING_API ./Source/ | grep -v Change | cut -d: -f1 | sort -u | xargs -n1 -I{} gsed -i 's/WTF_EXPORT_STRING_API/WTF_EXPORT_PRIVATE/g' {}
Yusuke Suzuki
Comment 4 2018-03-29 19:10:30 PDT
Comment on attachment 336830 [details] patch r=me
WebKit Commit Bot
Comment 5 2018-03-29 19:36:08 PDT
Comment on attachment 336830 [details] patch Clearing flags on attachment: 336830 Committed r230090: <https://trac.webkit.org/changeset/230090>
WebKit Commit Bot
Comment 6 2018-03-29 19:36:09 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.