Bug 184145

Summary: Move PingHandle to WebKitLegacy
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch youennf: review+

Alex Christensen
Reported 2018-03-29 12:12:29 PDT
Move PingHandle to WebKitLegacy
Attachments
Patch (28.41 KB, patch)
2018-03-29 12:15 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (29.00 KB, patch)
2018-03-29 13:03 PDT, Alex Christensen 		youennf: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2018-03-29 12:15:30 PDT
Created attachment 336792 [details] Patch
Alex Christensen
Comment 2 2018-03-29 13:03:12 PDT
Created attachment 336796 [details] Patch
youenn fablet
Comment 3 2018-04-04 15:22:03 PDT
Comment on attachment 336796 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=336796&action=review > Source/WebKitLegacy/WebCoreSupport/PingHandle.h:-33 > -namespace WebCore { Shouldn't it be in namespace WebKit?
Alex Christensen
Comment 4 2018-04-04 15:26:48 PDT
Most of WebKitLegacy is just in the global namespace. namespace WebKit usually means modern WebKit.
Alex Christensen
Comment 5 2018-04-04 15:28:38 PDT
http://trac.webkit.org/r230279
Radar WebKit Bug Importer
Comment 6 2018-04-04 15:29:15 PDT
<rdar://problem/39190530>
Note You need to log in before you can comment on or make changes to this bug.