Bug 184129

Summary:

[Web Animations] CSSTransition objects should have fill: backwards to allow seeking prior to start time

Product:

WebKit

Reporter:

Antoine Quint <graouts>

Component:

New Bugs

Assignee:

Antoine Quint <graouts>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dino, ews-watchlist, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews102 for mac-sierra	none
Archive of layout-test-results from ews105 for mac-sierra-wk2	none
Archive of layout-test-results from ews122 for ios-simulator-wk2	none
Archive of layout-test-results from ews117 for mac-sierra	none
Patch	none
Archive of layout-test-results from ews114 for mac-sierra	none
Archive of layout-test-results from ews205 for win-future	none
Patch	dino: review+

Antoine Quint

Reported 2018-03-29 00:35:32 PDT

[Web Animations] CSSTransition objects should have fill: backwards to allow seeking prior to start time

Attachments
Patch (7.06 KB, patch) 2018-03-29 00:36 PDT, Antoine Quint	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews102 for mac-sierra (2.26 MB, application/zip) 2018-03-29 01:40 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews105 for mac-sierra-wk2 (2.71 MB, application/zip) 2018-03-29 01:46 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews122 for ios-simulator-wk2 (2.25 MB, application/zip) 2018-03-29 02:12 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews117 for mac-sierra (3.13 MB, application/zip) 2018-03-29 02:15 PDT, EWS Watchlist	no flags	Details
Patch (10.10 KB, patch) 2018-03-29 02:38 PDT, Antoine Quint	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews114 for mac-sierra (2.99 MB, application/zip) 2018-03-29 04:06 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews205 for win-future (12.15 MB, application/zip) 2018-03-29 08:38 PDT, EWS Watchlist	no flags	Details
Patch (6.83 KB, patch) 2018-03-29 22:44 PDT, Antoine Quint	dino: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Antoine Quint

Comment 1 2018-03-29 00:36:47 PDT

Created attachment 336753 [details] Patch

EWS Watchlist

Comment 2 2018-03-29 01:40:37 PDT

Comment on attachment 336753 [details] Patch Attachment 336753 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/7134492 New failing tests: imported/mozilla/css-transitions/test_event-dispatch.html webanimations/css-transitions.html

EWS Watchlist

Comment 3 2018-03-29 01:40:39 PDT

Created attachment 336755 [details] Archive of layout-test-results from ews102 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 4 2018-03-29 01:46:58 PDT

Comment on attachment 336753 [details] Patch Attachment 336753 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/7134513 New failing tests: imported/mozilla/css-transitions/test_event-dispatch.html webanimations/css-transitions.html

EWS Watchlist

Comment 5 2018-03-29 01:46:59 PDT

Created attachment 336757 [details] Archive of layout-test-results from ews105 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 6 2018-03-29 02:12:25 PDT

Comment on attachment 336753 [details] Patch Attachment 336753 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/7134543 New failing tests: imported/mozilla/css-transitions/test_event-dispatch.html webanimations/css-transitions.html

EWS Watchlist

Comment 7 2018-03-29 02:12:27 PDT

Created attachment 336758 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 8 2018-03-29 02:15:00 PDT

Comment on attachment 336753 [details] Patch Attachment 336753 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/7134561 New failing tests: animations/keyframes-iteration-count-non-integer.html imported/mozilla/css-transitions/test_event-dispatch.html animations/missing-keyframe-properties-timing-function.html webanimations/css-transitions.html

EWS Watchlist

Comment 9 2018-03-29 02:15:01 PDT

Created attachment 336759 [details] Archive of layout-test-results from ews117 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-sierra Platform: Mac OS X 10.12.6

Antoine Quint

Comment 10 2018-03-29 02:38:25 PDT

Created attachment 336760 [details] Patch

EWS Watchlist

Comment 11 2018-03-29 04:06:43 PDT

Comment on attachment 336760 [details] Patch Attachment 336760 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/7135331 New failing tests: animations/keyframes-iteration-count-non-integer.html animations/missing-keyframe-properties-timing-function.html

EWS Watchlist

Comment 12 2018-03-29 04:06:45 PDT

Created attachment 336763 [details] Archive of layout-test-results from ews114 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 13 2018-03-29 08:38:09 PDT

Comment on attachment 336760 [details] Patch Attachment 336760 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/7136926 New failing tests: http/tests/security/local-video-source-from-remote.html

EWS Watchlist

Comment 14 2018-03-29 08:38:20 PDT

Created attachment 336774 [details] Archive of layout-test-results from ews205 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews205 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

Antoine Quint

Comment 15 2018-03-29 22:44:28 PDT

Created attachment 336841 [details] Patch

Dean Jackson

Comment 16 2018-03-30 11:29:59 PDT

Comment on attachment 336841 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=336841&action=review > Source/WebCore/animation/KeyframeEffectReadOnly.cpp:874 > + // We don't yet have blending keyframes to compare with, so these wouldn't be new keyframes, but the fisrt ones. typo first

Antoine Quint

Comment 17 2018-03-30 11:48:28 PDT

Committed r230112: <https://trac.webkit.org/changeset/230112>

Radar WebKit Bug Importer

Comment 18 2018-03-30 11:50:19 PDT

<rdar://problem/39046945>

Note You need to log in before you can comment on or make changes to this bug.