Bug 184129

Summary: [Web Animations] CSSTransition objects should have fill: backwards to allow seeking prior to start time
Product: WebKit Reporter: Antoine Quint <graouts>
Component: New BugsAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, ews-watchlist, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews102 for mac-sierra
none
Archive of layout-test-results from ews105 for mac-sierra-wk2
none
Archive of layout-test-results from ews122 for ios-simulator-wk2
none
Archive of layout-test-results from ews117 for mac-sierra
none
Patch
none
Archive of layout-test-results from ews114 for mac-sierra
none
Archive of layout-test-results from ews205 for win-future
none
Patch dino: review+

Description Antoine Quint 2018-03-29 00:35:32 PDT
[Web Animations] CSSTransition objects should have fill: backwards to allow seeking prior to start time
Comment 1 Antoine Quint 2018-03-29 00:36:47 PDT
Created attachment 336753 [details]
Patch
Comment 2 EWS Watchlist 2018-03-29 01:40:37 PDT
Comment on attachment 336753 [details]
Patch

Attachment 336753 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/7134492

New failing tests:
imported/mozilla/css-transitions/test_event-dispatch.html
webanimations/css-transitions.html
Comment 3 EWS Watchlist 2018-03-29 01:40:39 PDT
Created attachment 336755 [details]
Archive of layout-test-results from ews102 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 4 EWS Watchlist 2018-03-29 01:46:58 PDT
Comment on attachment 336753 [details]
Patch

Attachment 336753 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/7134513

New failing tests:
imported/mozilla/css-transitions/test_event-dispatch.html
webanimations/css-transitions.html
Comment 5 EWS Watchlist 2018-03-29 01:46:59 PDT
Created attachment 336757 [details]
Archive of layout-test-results from ews105 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 6 EWS Watchlist 2018-03-29 02:12:25 PDT
Comment on attachment 336753 [details]
Patch

Attachment 336753 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/7134543

New failing tests:
imported/mozilla/css-transitions/test_event-dispatch.html
webanimations/css-transitions.html
Comment 7 EWS Watchlist 2018-03-29 02:12:27 PDT
Created attachment 336758 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6
Comment 8 EWS Watchlist 2018-03-29 02:15:00 PDT
Comment on attachment 336753 [details]
Patch

Attachment 336753 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/7134561

New failing tests:
animations/keyframes-iteration-count-non-integer.html
imported/mozilla/css-transitions/test_event-dispatch.html
animations/missing-keyframe-properties-timing-function.html
webanimations/css-transitions.html
Comment 9 EWS Watchlist 2018-03-29 02:15:01 PDT
Created attachment 336759 [details]
Archive of layout-test-results from ews117 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 10 Antoine Quint 2018-03-29 02:38:25 PDT
Created attachment 336760 [details]
Patch
Comment 11 EWS Watchlist 2018-03-29 04:06:43 PDT
Comment on attachment 336760 [details]
Patch

Attachment 336760 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/7135331

New failing tests:
animations/keyframes-iteration-count-non-integer.html
animations/missing-keyframe-properties-timing-function.html
Comment 12 EWS Watchlist 2018-03-29 04:06:45 PDT
Created attachment 336763 [details]
Archive of layout-test-results from ews114 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 13 EWS Watchlist 2018-03-29 08:38:09 PDT
Comment on attachment 336760 [details]
Patch

Attachment 336760 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/7136926

New failing tests:
http/tests/security/local-video-source-from-remote.html
Comment 14 EWS Watchlist 2018-03-29 08:38:20 PDT
Created attachment 336774 [details]
Archive of layout-test-results from ews205 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews205  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 15 Antoine Quint 2018-03-29 22:44:28 PDT
Created attachment 336841 [details]
Patch
Comment 16 Dean Jackson 2018-03-30 11:29:59 PDT
Comment on attachment 336841 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336841&action=review

> Source/WebCore/animation/KeyframeEffectReadOnly.cpp:874
> +    // We don't yet have blending keyframes to compare with, so these wouldn't be new keyframes, but the fisrt ones.

typo first
Comment 17 Antoine Quint 2018-03-30 11:48:28 PDT
Committed r230112: <https://trac.webkit.org/changeset/230112>
Comment 18 Radar WebKit Bug Importer 2018-03-30 11:50:19 PDT
<rdar://problem/39046945>