Bug 184081 – Fails to build webkitgtk+ after git-svn-id: http://svn.webkit.org/repository/webkit/trunk@229877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

• Component: WebKitGTK
• Status: RESOLVED FIXED

[Milan Crha]

After commit 700788272e59413f03b1ba7ea4e896f16fe78a1b, which references itself as:

    Unreviewed, silence unused variable warning
    
    Patch by Michael Catanzaro <[e-mail]> on 2018-03-22
    
    * UIProcess/WebPageProxy.cpp:
    (WebKit::WebPageProxy::decidePolicyForNavigationAction):
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@229877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

fails to build here. The only code change there was:

            return receivedPolicyDecision(PolicyAction::Ignore, *frame, listenerID, &m_navigationState->navigation(newNavigationID), { });
  +#else
  +    UNUSED(newNavigationID);
    #endif

where the 'UNUSED' is actually meant to be 'UNUSED_PARAM'.

[Michael Catanzaro]

Yes.

And yet, what I don't understand is: why does it build for me? Why does it build for all the bots? ENABLE(CONTENT_FILTERING) is always disabled for GTK. I'll try to investigate.

[Michael Catanzaro]

Well this is weird. When I change it to:

#if ENABLE(CONTENT_FILTERING)
    if (frame->didHandleContentFilterUnblockNavigation(request))
        return receivedPolicyDecision(PolicyAction::Ignore, *frame, listenerID, &m_navigationState->navigation(newNavigationID), { });
#else
aoeunhtsaoeuhtns;
    UNUSED(newNavigationID);
#endif

then it fails to build, so the file is definitely compiled without ENABLE(CONTENT_FILTERING). I don't know why it doesn't work for you, and I don't know where UNUSED() is defined. Anyway, I clearly meant UNUSED_PARAM(), so I'll just change it.

[Michael Catanzaro]

Committed r230032: <https://trac.webkit.org/changeset/230032>

[Michael Catanzaro]

It's defined here:

bmalloc/bmalloc/BAssert.h:#define UNUSED(x) ((void)x)

Were you building with -DUSE_SYSTEM_MALLOC=ON? :)

Anyway, clearly a mistake, but it *did* fix the unused parameter warning!

[Milan Crha]

True, -DUSE_SYSTEM_MALLOC=ON is one of my arguments to CMake.