Bug 184064

Summary:

Thread safety issue in IDBFactory' shouldThrowSecurityException()

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

WebCore Misc.

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

beidson, commit-queue, dbates, rniwa, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

184059

Attachments:

Description	Flags
Patch	none
Patch	none

Chris Dumez

Reported 2018-03-27 18:45:09 PDT

Thread safety issue in IDBFactory' shouldThrowSecurityException(). It is getting called on a non-main thread but uses the SchemeRegistry: ASSERTION FAILED: isMainThread() ./platform/SchemeRegistry.cpp(118) : URLSchemesMap &WebCore::localURLSchemes() 1 0x25072c88d WTFCrash 2 0x24355e1ca WebCore::localURLSchemes() 3 0x24355e420 WebCore::SchemeRegistry::shouldTreatURLSchemeAsLocal(WTF::String const&) 4 0x2434597e9 WebCore::SecurityOrigin::isLocal() const 5 0x24345ace2 WebCore::SecurityOrigin::canAccessStorage(WebCore::SecurityOrigin const*, WebCore::SecurityOrigin::ShouldAllowFromThirdParty) const 6 0x24209e0f2 WebCore::SecurityOrigin::canAccessDatabase(WebCore::SecurityOrigin const&) const 7 0x242092e9d WebCore::shouldThrowSecurityException(WebCore::ScriptExecutionContext&) 8 0x242093022 WebCore::IDBFactory::deleteDatabase(WebCore::ScriptExecutionContext&, WTF::String const&) 9 0x24168d8a2 WebCore::jsIDBFactoryPrototypeFunctionDeleteDatabaseBody(JSC::ExecState*, WebCore::JSIDBFactory*, JSC::ThrowScope&)

Attachments
Patch (3.87 KB, patch) 2018-03-27 19:17 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (3.85 KB, patch) 2018-03-28 12:59 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2018-03-27 19:17:27 PDT

Created attachment 336635 [details] Patch

Ryosuke Niwa

Comment 2 2018-03-27 22:41:35 PDT

Comment on attachment 336635 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=336635&action=review > Source/WebCore/ChangeLog:14 > + methods are often called from background threads, this match make SecurityOrigin::isLocal() You mean "this match" -> "this patch"?

Chris Dumez

Comment 3 2018-03-28 12:59:32 PDT

Created attachment 336701 [details] Patch

WebKit Commit Bot

Comment 4 2018-03-28 13:36:08 PDT

Comment on attachment 336701 [details] Patch Clearing flags on attachment: 336701 Committed r230044: <https://trac.webkit.org/changeset/230044>

WebKit Commit Bot

Comment 5 2018-03-28 13:36:09 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 6 2018-03-28 13:37:23 PDT

<rdar://problem/38969800>

Note You need to log in before you can comment on or make changes to this bug.