Bug 18405

Summary: [GTK] Property setters do not call g_object_notify()
Product: WebKit Reporter: Marco Barisione <marco.barisione>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: christian
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Add missing g_object_notify in WebKitWebView none

Marco Barisione
Reported 2008-04-10 08:34:34 PDT
If a property is set using the _set_foobar() method then the notify::foobar method is not emitted. We should add a call to g_object_notify to every setter, if possible emitting the signal only if the new value is different from the old one.
Attachments
Add missing g_object_notify in WebKitWebView (1.15 KB, patch)
2008-06-15 07:13 PDT, Christian Dywan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Christian Dywan
Comment 1 2008-06-15 07:13:08 PDT
Created attachment 21711 [details] Add missing g_object_notify in WebKitWebView There are in fact three cases in WebKitWebView where g_object_notify is missing, this patch fixes them.
Christian Dywan
Comment 2 2008-06-15 07:42:19 PDT
Comment on attachment 21711 [details] Add missing g_object_notify in WebKitWebView Committed in revision 34571.
Note You need to log in before you can comment on or make changes to this bug.