Bug 184047

Summary: Web Inspector: Modernize some utility functions
Product: WebKit Reporter: Timothy Hatcher <timothy>
Component: Web InspectorAssignee: Timothy Hatcher <timothy>
Status: RESOLVED FIXED    
Severity: Trivial CC: commit-queue, inspector-bugzilla-changes, mattbaker, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Timothy Hatcher
Reported 2018-03-27 10:11:49 PDT
We can use let and iterators in a few common utility functions.
Attachments
Patch (3.75 KB, patch)
2018-03-27 10:28 PDT, Timothy Hatcher 		no flags
DetailsFormatted DiffDiff
Patch (7.13 KB, patch)
2018-03-27 16:39 PDT, Timothy Hatcher 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Timothy Hatcher
Comment 1 2018-03-27 10:28:28 PDT
Created attachment 336593 [details] Patch
Matt Baker
Comment 2 2018-03-27 12:11:13 PDT
Comment on attachment 336593 [details] Patch r=me, nice cleanup. It would be good to get our utilities test coverage to 100% at some point, so this can of refactoring can be done with greater confidence. Tests for enclosingNodeOrSelfWithClass, enclosingNodeOrSelfWithNodeNameInArray, and escapeCharacters would be nice to include before landing.
Timothy Hatcher
Comment 3 2018-03-27 16:39:30 PDT
Created attachment 336630 [details] Patch
Timothy Hatcher
Comment 4 2018-03-27 16:40:34 PDT
(In reply to Matt Baker from comment #2) > Comment on attachment 336593 [details] > Patch > > r=me, nice cleanup. > > It would be good to get our utilities test coverage to 100% at some point, > so this can of refactoring can be done with greater confidence. Tests for > enclosingNodeOrSelfWithClass, enclosingNodeOrSelfWithNodeNameInArray, and > escapeCharacters would be nice to include before landing. I added tests for escapeCharacters, since there was an existing test for string utilities.
WebKit Commit Bot
Comment 5 2018-03-27 19:51:23 PDT
Comment on attachment 336630 [details] Patch Clearing flags on attachment: 336630 Committed r230021: <https://trac.webkit.org/changeset/230021>
WebKit Commit Bot
Comment 6 2018-03-27 19:51:24 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2018-03-27 19:52:23 PDT
<rdar://problem/38940079>
Note You need to log in before you can comment on or make changes to this bug.