Bug 184030

Summary: Adopt WK_ALTERNATE_FRAMEWORKS_DIR in WebKit
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, mitz, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Tim Horton
Reported 2018-03-26 20:08:00 PDT
Adopt WK_ALTERNATE_FRAMEWORKS_DIR in WebKit
Attachments
Patch (6.42 KB, patch)
2018-03-26 20:11 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-03-26 20:08:25 PDT
<rdar://problem/38895281>
Tim Horton
Comment 2 2018-03-26 20:11:10 PDT
Created attachment 336562 [details] Patch
mitz
Comment 3 2018-03-26 20:12:50 PDT
Comment on attachment 336562 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=336562&action=review > Source/WebKitLegacy/mac/Configurations/Base.xcconfig:129 > +WK_ALTERNATE_WEBKIT_SDK_PATH = $(WK_ALTERNATE_WEBKIT_SDK_PATH_$(WK_USE_ALTERNATE_FRAMEWORKS_DIR)); > +WK_ALTERNATE_WEBKIT_SDK_PATH_YES = $(WK_ALTERNATE_FRAMEWORKS_DIR)/; :|
Tim Horton
Comment 4 2018-03-26 20:24:04 PDT
Comment on attachment 336562 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=336562&action=review >> Source/WebKitLegacy/mac/Configurations/Base.xcconfig:129 >> +WK_ALTERNATE_WEBKIT_SDK_PATH_YES = $(WK_ALTERNATE_FRAMEWORKS_DIR)/; > > :| Every patch needs to touch at least one thing one level below. Thank you!
WebKit Commit Bot
Comment 5 2018-03-26 21:07:45 PDT
Comment on attachment 336562 [details] Patch Clearing flags on attachment: 336562 Committed r229991: <https://trac.webkit.org/changeset/229991>
WebKit Commit Bot
Comment 6 2018-03-26 21:07:46 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.