Bug 184017

Summary: [ASan] Allow Ref<> to be swapped
Product: WebKit Reporter: Antoine Quint <graouts>
Component: New BugsAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, dbates, ews-watchlist, jfbastien, koivisto, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch jfbastien: review+

Antoine Quint
Reported 2018-03-26 11:28:51 PDT
[ASan] Allow Ref<> to be swapped
Attachments
Patch (1.62 KB, patch)
2018-03-26 11:32 PDT, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Patch (2.45 KB, patch)
2018-03-26 12:01 PDT, Antoine Quint 		jfbastien: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antoine Quint
Comment 1 2018-03-26 11:32:09 PDT
Created attachment 336529 [details] Patch
Antoine Quint
Comment 2 2018-03-26 11:33:26 PDT
<rdar://problem/36336787>
JF Bastien
Comment 3 2018-03-26 11:34:58 PDT
Comment on attachment 336529 [details] Patch I think you also need to un poison assignToHashTableEmptyValue and replace.
Antti Koivisto
Comment 4 2018-03-26 11:35:23 PDT
Comment on attachment 336529 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=336529&action=review > Source/WTF/wtf/Ref.h:173 > +#if ASAN_ENABLED > + if (__asan_address_is_poisoned(this)) > + __asan_unpoison_memory_region(this, sizeof(*this)); > +#endif > Ref movedReference = WTFMove(reference); Too much indentation. > Source/WTF/wtf/Ref.h:185 > +#if ASAN_ENABLED > + if (__asan_address_is_poisoned(this)) > + __asan_unpoison_memory_region(this, sizeof(*this)); > +#endif Here too.
Antoine Quint
Comment 5 2018-03-26 12:01:52 PDT
Created attachment 336531 [details] Patch
JF Bastien
Comment 6 2018-03-26 12:40:32 PDT
Comment on attachment 336531 [details] Patch r=me
Antoine Quint
Comment 7 2018-03-26 13:16:55 PDT
Committed r229985: <https://trac.webkit.org/changeset/229985>
Note You need to log in before you can comment on or make changes to this bug.