Bug 183984

Summary: [JSC] Remove arity fixup check if the number of parameters is 1
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews115 for mac-sierra
none
Patch
none
Patch
none
Patch mark.lam: review+

Description Yusuke Suzuki 2018-03-24 10:53:58 PDT
[Baseline] Remove arity fixup check if the number of parameters is 1
Comment 1 Yusuke Suzuki 2018-03-24 10:54:43 PDT
Created attachment 336476 [details]
Patch
Comment 2 Yusuke Suzuki 2018-03-24 11:14:03 PDT
Comment on attachment 336476 [details]
Patch

Extend this to DFG and FTL too.
Comment 3 EWS Watchlist 2018-03-24 12:52:16 PDT
Comment on attachment 336476 [details]
Patch

Attachment 336476 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/7088842

New failing tests:
imported/w3c/web-platform-tests/workers/semantics/navigation/001.html
fast/workers/DedicatedWorkerGlobalScope-immutable-prototype.html
fast/workers/worker-gc.html
fast/workers/WorkerGlobalScope-properties-prototype.html
fast/workers/worker-replace-global-constructor.html
fast/workers/constructor-proto.html
fast/workers/self-hasOwnProperty.html
fast/workers/self-toString.html
fast/workers/worker-location.html
fast/workers/DedicatedWorkerGlobalScope-prototype-chain.html
fast/workers/worker-context-gc.html
fast/workers/worker-lifecycle.html
fast/workers/worker-event-listener.html
fast/workers/use-machine-stack.html
http/tests/websocket/tests/hybi/workers/no-onmessage-in-sync-op.html
fast/workers/worker-gc2.html
fast/workers/postMessage-missing-parameter.html
fast/workers/worker-navigator.html
fast/workers/dedicated-worker-lifecycle.html
Comment 4 EWS Watchlist 2018-03-24 12:52:17 PDT
Created attachment 336484 [details]
Archive of layout-test-results from ews115 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 5 Yusuke Suzuki 2018-04-01 13:30:25 PDT
Created attachment 336960 [details]
Patch
Comment 6 Yusuke Suzuki 2018-04-01 13:40:03 PDT
Created attachment 336961 [details]
Patch
Comment 7 Yusuke Suzuki 2018-04-02 11:01:39 PDT
Created attachment 337001 [details]
Patch
Comment 8 Yusuke Suzuki 2018-04-07 07:09:24 PDT
Ping?
Comment 9 Yusuke Suzuki 2018-04-30 09:45:43 PDT
Ping?
Comment 10 Mark Lam 2018-04-30 09:58:17 PDT
Comment on attachment 337001 [details]
Patch

r=me
Comment 11 Yusuke Suzuki 2018-04-30 11:01:52 PDT
Thanks!
Comment 12 Yusuke Suzuki 2018-04-30 11:02:13 PDT
Committed r231160: <https://trac.webkit.org/changeset/231160>
Comment 13 Radar WebKit Bug Importer 2018-04-30 11:03:52 PDT
<rdar://problem/39840939>