Include security origin in the service worker process name

• Component: Service Workers
• Status: RESOLVED FIXED

[Chris Dumez]

Include security origin in the service worker process name to facilitate debugging. This way, we can differentiate which service worker process is used for which origin in activity monitor.

[Chris Dumez]

Created attachment 336298 [details]
Patch

[youenn fablet]

Comment on attachment 336298 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336298&action=review

> Source/WebKit/ChangeLog:9
> +        can differentiate which service worker process is used for which origin in activity monitor.

Is there a privacy concern here, like some application running in the device that could easily detect at any time whether the user is browsing to a given origin or not?

> Source/WebCore/English.lproj/Localizable.strings:-120
> -

Do we need all these changes?

[Chris Dumez]

Comment on attachment 336298 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336298&action=review

>> Source/WebKit/ChangeLog:9
>> +        can differentiate which service worker process is used for which origin in activity monitor.
> 
> Is there a privacy concern here, like some application running in the device that could easily detect at any time whether the user is browsing to a given origin or not?

We already display the origin for WebProcess so I do not think service workers are any different. That said, I haven't found the code that shows the WebProcess url in activity monitor yet.

>> Source/WebCore/English.lproj/Localizable.strings:-120
>> -
> 
> Do we need all these changes?

I merely ran:
Tools/Scripts/update-webkit-localizable-strings

The file happened to be quite out of date.

[Chris Dumez]

Comment on attachment 336298 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336298&action=review

>>> Source/WebKit/ChangeLog:9
>>> +        can differentiate which service worker process is used for which origin in activity monitor.
>> 
>> Is there a privacy concern here, like some application running in the device that could easily detect at any time whether the user is browsing to a given origin or not?
> 
> We already display the origin for WebProcess so I do not think service workers are any different. That said, I haven't found the code that shows the WebProcess url in activity monitor yet.

Looks like it is done slightly differently for WebProcesses via WebProcess::updateActivePages(). I'll see if I can do the same.

[Chris Dumez]

Comment on attachment 336298 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336298&action=review

>>>> Source/WebKit/ChangeLog:9
>>>> +        can differentiate which service worker process is used for which origin in activity monitor.
>>> 
>>> Is there a privacy concern here, like some application running in the device that could easily detect at any time whether the user is browsing to a given origin or not?
>> 
>> We already display the origin for WebProcess so I do not think service workers are any different. That said, I haven't found the code that shows the WebProcess url in activity monitor yet.
> 
> Looks like it is done slightly differently for WebProcesses via WebProcess::updateActivePages(). I'll see if I can do the same.

Actually, both seem to call _LSSetApplicationInformationItem(). In the service worker process case, the origin does not change so we can set it right away in initializeProcessName().

[WebKit Commit Bot]

Comment on attachment 336298 [details]
Patch

Clearing flags on attachment: 336298

Committed r229878: <https://trac.webkit.org/changeset/229878>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/38776833>