Bug 183895

Summary: [TexMap] Make TextureMapperContextAttributes thread-specific
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Zan Dobersek
Reported 2018-03-22 05:17:56 PDT
[TexMap] Make TextureMapperContextAttributes thread-specific
Attachments
Patch (14.09 KB, patch)
2018-03-22 05:25 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch for landing (14.18 KB, patch)
2018-03-22 11:01 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2018-03-22 05:25:55 PDT
Created attachment 336274 [details] Patch
Carlos Garcia Campos
Comment 2 2018-03-22 07:16:22 PDT
Comment on attachment 336274 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=336274&action=review > Source/WebCore/platform/graphics/texmap/TextureMapperContextAttributes.cpp:42 > + static WTF::ThreadSpecific<TextureMapperContextAttributes>* s_textureMapperContextAttributes; > + if (!s_textureMapperContextAttributes) > + s_textureMapperContextAttributes = new WTF::ThreadSpecific<TextureMapperContextAttributes>; > + return *s_textureMapperContextAttributes; Should we use std::once here?
Zan Dobersek
Comment 3 2018-03-22 10:55:17 PDT
Comment on attachment 336274 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=336274&action=review >> Source/WebCore/platform/graphics/texmap/TextureMapperContextAttributes.cpp:42 >> + return *s_textureMapperContextAttributes; > > Should we use std::once here? Yes.
Zan Dobersek
Comment 4 2018-03-22 11:01:29 PDT
Created attachment 336289 [details] Patch for landing
Zan Dobersek
Comment 5 2018-03-22 11:07:07 PDT
Comment on attachment 336289 [details] Patch for landing Clearing flags on attachment: 336289 Committed r229857: <https://trac.webkit.org/changeset/229857>
Zan Dobersek
Comment 6 2018-03-22 11:07:10 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2018-03-22 11:08:32 PDT
<rdar://problem/38758602>
Note You need to log in before you can comment on or make changes to this bug.