Bug 183877

Summary: SVG root is skipped while marking percentage height descendants dirty.
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, ews-watchlist, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 183572    
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews206 for win-future none

Description zalan 2018-03-21 15:59:32 PDT
and it leads to gaps in the ancestor chain (child is set to dirty while the parent is not) and the layout traversal logic expects no gaps in the needsLayout flags.
Comment 1 zalan 2018-03-21 16:00:15 PDT
see also bug 183874
Comment 2 zalan 2018-03-21 20:59:34 PDT
Created attachment 336259 [details]
Patch
Comment 3 EWS Watchlist 2018-03-21 23:00:57 PDT
Comment on attachment 336259 [details]
Patch

Attachment 336259 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/7059658

New failing tests:
http/tests/preload/download_resources.html
Comment 4 EWS Watchlist 2018-03-21 23:01:09 PDT
Created attachment 336261 [details]
Archive of layout-test-results from ews206 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 5 zalan 2018-03-22 07:19:18 PDT
(In reply to Build Bot from comment #3)
> Comment on attachment 336259 [details]
> Patch
> 
> Attachment 336259 [details] did not pass win-ews (win):
> Output: http://webkit-queues.webkit.org/results/7059658
> 
> New failing tests:
> http/tests/preload/download_resources.html
Highly unlikely.
Comment 6 WebKit Commit Bot 2018-03-22 07:54:17 PDT
Comment on attachment 336259 [details]
Patch

Clearing flags on attachment: 336259

Committed r229849: <https://trac.webkit.org/changeset/229849>
Comment 7 WebKit Commit Bot 2018-03-22 07:54:19 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2018-03-22 07:56:11 PDT
<rdar://problem/38751619>