Bug 183876

Summary: Make AVFoundationEnabled preference available on iOS
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ryanhaddad, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
commit-queue: commit-queue-
Fix the test on iOS.
none
Fix the test on iOS. none

Eric Carlson
Reported 2018-03-21 15:40:51 PDT
Make AVFoundationEnabled preference available on iOS
Attachments
Patch (21.52 KB, patch)
2018-03-26 14:17 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch (24.21 KB, patch)
2018-03-26 20:36 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch (1.62 KB, patch)
2018-03-27 15:13 PDT, Eric Carlson 		commit-queue: commit-queue-
DetailsFormatted DiffDiff
Fix the test on iOS. (1.50 KB, patch)
2018-03-27 15:22 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Fix the test on iOS. (1.82 KB, patch)
2018-03-27 15:51 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-03-21 15:41:17 PDT
<rdar://problem/38726459>
Eric Carlson
Comment 2 2018-03-26 14:17:08 PDT
Created attachment 336543 [details] Patch
youenn fablet
Comment 3 2018-03-26 14:31:20 PDT
Comment on attachment 336543 [details] Patch r=me once non COCOA bots are happy. I would add a test for the m_error early return and a comment to the added line in prepareLoad.
Eric Carlson
Comment 4 2018-03-26 20:36:07 PDT
Created attachment 336564 [details] Patch
WebKit Commit Bot
Comment 5 2018-03-27 04:39:57 PDT
Comment on attachment 336564 [details] Patch Clearing flags on attachment: 336564 Committed r229995: <https://trac.webkit.org/changeset/229995>
WebKit Commit Bot
Comment 6 2018-03-27 04:39:59 PDT
All reviewed patches have been landed. Closing bug.
Ryan Haddad
Comment 7 2018-03-27 12:06:56 PDT
The API test added with this change is timing out on iOS bots: https://build.webkit.org/builders/Apple%20iOS%2011%20Simulator%20Release%20WK2%20%28Tests%29/builds/3970
Eric Carlson
Comment 8 2018-03-27 15:13:15 PDT
Reopening to attach new patch.
Eric Carlson
Comment 9 2018-03-27 15:13:15 PDT
Created attachment 336621 [details] Patch
WebKit Commit Bot
Comment 10 2018-03-27 15:15:33 PDT
Comment on attachment 336621 [details] Patch Rejecting attachment 336621 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 336621, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/Tools/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.webkit.org/results/7117537
Eric Carlson
Comment 11 2018-03-27 15:22:24 PDT
Created attachment 336624 [details] Fix the test on iOS.
Eric Carlson
Comment 12 2018-03-27 15:51:26 PDT
Created attachment 336627 [details] Fix the test on iOS.
WebKit Commit Bot
Comment 13 2018-03-27 16:16:38 PDT
Comment on attachment 336627 [details] Fix the test on iOS. Clearing flags on attachment: 336627 Committed r230013: <https://trac.webkit.org/changeset/230013>
WebKit Commit Bot
Comment 14 2018-03-27 16:16:39 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.