| Summary: | Have select multiple controls follow system appearance | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Megan Gardner <megan_gardner> | ||||||
| Component: | Forms | Assignee: | Megan Gardner <megan_gardner> | ||||||
| Status: | CLOSED INVALID | ||||||||
| Severity: | Normal | CC: | achristensen, cdumez, ews-watchlist, simon.fraser, thorton, webkit-bug-importer, wenson_hsieh | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Megan Gardner
2018-03-19 21:14:33 PDT
Created attachment 336097 [details]
Patch
Comment on attachment 336097 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=336097&action=review > Source/WebCore/css/html.css:365 > + color: ButtonText; Just because they’re case insensitive doesn’t mean you need to go flaunting it :) I think “buttontext” or maybe “buttonText” but not this. > Source/WebCore/css/html.css:902 > + color: ButtonText; > + background-color: InactiveCaption; Ditto. Also I’m really not sure how this is going to go for the other platforms. We might have to PLATFORM(MAC) this? Do other people have colors for these? Comment on attachment 336097 [details] Patch Attachment 336097 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/7035602 Number of test failures exceeded the failure limit. Created attachment 336108 [details]
Archive of layout-test-results from ews204 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews204 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Updated to use semantic colors in a later patch, this is not needed. Comment on attachment 336097 [details]
Patch
This has been requesting review for more than one year. If this is still needed, please rebase and re-request review.
|