Bug 183760

Summary: NetworkStateNotifier::updateStateWithoutNotifying() is inefficient
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: PlatformAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, ap, beidson, commit-queue, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2018-03-19 19:04:11 PDT
NetworkStateNotifier::updateStateWithoutNotifying() is inefficient. In particular, the call to SCDynamicStoreCopyKeyList() is very expensive and can be avoided.
Attachments
Patch (3.66 KB, patch)
2018-03-19 19:12 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (2.42 KB, patch)
2018-03-23 12:26 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2018-03-19 19:04:26 PDT
<rdar://problem/37093299>
Chris Dumez
Comment 2 2018-03-19 19:12:43 PDT
Created attachment 336095 [details] Patch
Chris Dumez
Comment 3 2018-03-23 12:26:19 PDT
Created attachment 336404 [details] Patch
Chris Dumez
Comment 4 2018-03-23 16:46:54 PDT
Comment on attachment 336404 [details] Patch Clearing flags on attachment: 336404 Committed r229935: <https://trac.webkit.org/changeset/229935>
Chris Dumez
Comment 5 2018-03-23 16:46:56 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-03-23 16:47:24 PDT
<rdar://problem/38812960>
Note You need to log in before you can comment on or make changes to this bug.