Bug 183757

Summary: Add a layout test verifying AppCache resource fetches have the document's cookie in place
Product: WebKit Reporter: Brady Eidson <beidson>
Component: Tools / TestsAssignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, aestes, cdumez, commit-queue, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
Patch none

Brady Eidson
Reported 2018-03-19 16:51:11 PDT
Add a layout test verifying AppCache resource fetches have the document's cookie in place For a brief period we broke this. We refixed it on trunk. I'm adding a test to verify it remains fixed on trunk.
Attachments
patch (2.64 KB, patch)
2018-03-19 17:22 PDT, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Patch (3.72 KB, patch)
2018-03-19 18:37 PDT, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2018-03-19 17:12:14 PDT
Note: a test verifying the manifest file itself has these cookies set was landed in https://trac.webkit.org/changeset/229691/webkit This test is a further elaboration on that.
Brady Eidson
Comment 2 2018-03-19 17:22:06 PDT
Created attachment 336086 [details] patch I'm attaching this patch knowingly without a ChangeLog to get EWS to run on it. I will make a ChangeLog before I land.
Brady Eidson
Comment 3 2018-03-19 18:37:05 PDT
Created attachment 336094 [details] Patch
WebKit Commit Bot
Comment 4 2018-03-19 19:28:01 PDT
Comment on attachment 336094 [details] Patch Clearing flags on attachment: 336094 Committed r229733: <https://trac.webkit.org/changeset/229733>
WebKit Commit Bot
Comment 5 2018-03-19 19:28:03 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-03-19 19:29:20 PDT
<rdar://problem/38647111>
Note You need to log in before you can comment on or make changes to this bug.