Bug 183752 – The layout test fast/canvas/canvas-blending-global-alpha.html is failing when the WebContent process does not have WindowServer access.

• Component: WebCore Misc.
• Status: NEW

[Per Arne Vollan]

@@ -44,13 +44,13 @@
 Testing blend mode color-dodge
 PASS actualColor(0, 0)[0] is within 5 of 141.6
 PASS actualColor(0, 0)[1] is within 5 of 255
-PASS actualColor(0, 0)[2] is within 5 of 141.6
+FAIL actualColor(0, 0)[2] should be within 5 of 141.6. Was 135.
 PASS actualColor(0, 0)[3] is within 5 of 255
 
 Testing blend mode color-burn
 PASS actualColor(0, 0)[0] is within 5 of 129
 PASS actualColor(0, 0)[1] is within 5 of 255
-PASS actualColor(0, 0)[2] is within 5 of 116.69302325581394
+FAIL actualColor(0, 0)[2] should be within 5 of 116.69302325581394. Was 123.
 PASS actualColor(0, 0)[3] is within 5 of 255
 
 Testing blend mode hard-light
@@ -112,13 +112,13 @@
 Testing blend mode color-dodge
 PASS actualColor(0, 0)[0] is within 5 of 141.6
 PASS actualColor(0, 0)[1] is within 5 of 255
-PASS actualColor(0, 0)[2] is within 5 of 141.6
+FAIL actualColor(0, 0)[2] should be within 5 of 141.6. Was 135.
 PASS actualColor(0, 0)[3] is within 5 of 255
 
 Testing blend mode color-burn
 PASS actualColor(0, 0)[0] is within 5 of 129
 PASS actualColor(0, 0)[1] is within 5 of 255
-PASS actualColor(0, 0)[2] is within 5 of 116.69302325581394
+FAIL actualColor(0, 0)[2] should be within 5 of 116.69302325581394. Was 123.
 PASS actualColor(0, 0)[3] is within 5 of 255
 
 Testing blend mode hard-light

[Radar WebKit Bug Importer]

<rdar://problem/38635731>

[Per Arne Vollan]

This is the complete set of layout test regressions when blocking WindowServer access:

fast/canvas/canvas-blending-global-alpha.html
fast/canvas/canvas-scale-shadowBlur.html
inspector/canvas/recording-webgl-snapshots.html	webgl/1.0.2/conformance/uniforms/uniform-default-values.htm
webgl/webgl-texture-image-buffer-reuse.html

[Per Arne Vollan]

I forgot one timeout:

fast/canvas/webgl/read-pixels-test.html

[Per Arne Vollan]

Created attachment 337097 [details]
Patch

[EWS Watchlist]

Comment on attachment 337097 [details]
Patch

Attachment 337097 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/7195412

New failing tests:
http/tests/websocket/tests/hybi/no-subprotocol.html

[EWS Watchlist]

Created attachment 337102 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 337097 [details]
Patch

Attachment 337097 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/7195764

New failing tests:
sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A1.1_T2.html

[EWS Watchlist]

Created attachment 337106 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[Per Arne Vollan]

Created attachment 337130 [details]
Patch

[Per Arne Vollan]

Created attachment 337201 [details]
Patch

[Brent Fulgham]

Comment on attachment 337201 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337201&action=review

r=me if this is working as I suggested in my comments.

> Source/WebCore/platform/graphics/cocoa/GraphicsContext3DCocoa.mm:801
> +        return m_displayMask.value();

Is this value already getting set on the WebProcess through a message pass from the UIProcess? I think that was part of your OpenGL fix, right?

> Source/WebCore/platform/graphics/cocoa/IOSurface.mm:304
> +    uint32_t mask = GraphicsContext3D::getOpenGLDisplayMask();

if (uint32_t mask = GraphicsContext3D::getOpenGLDisplayMask())
    CGIOSurfaceContextSetDisplayMask(m_cgContext.get(), mask);

[Per Arne Vollan]

(In reply to Brent Fulgham from comment #11)
> Comment on attachment 337201 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=337201&action=review
> 
> r=me if this is working as I suggested in my comments.
> 
> > Source/WebCore/platform/graphics/cocoa/GraphicsContext3DCocoa.mm:801
> > +        return m_displayMask.value();
> 
> Is this value already getting set on the WebProcess through a message pass
> from the UIProcess? I think that was part of your OpenGL fix, right?
> 

Yes.

> > Source/WebCore/platform/graphics/cocoa/IOSurface.mm:304
> > +    uint32_t mask = GraphicsContext3D::getOpenGLDisplayMask();
> 
> if (uint32_t mask = GraphicsContext3D::getOpenGLDisplayMask())
>     CGIOSurfaceContextSetDisplayMask(m_cgContext.get(), mask);

Thanks for reviewing! I will update the patch before landing.

[Per Arne Vollan]

Created attachment 337218 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 337218 [details]
Patch

Rejecting attachment 337218 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 337218, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebCore/PAL/ChangeLog contains OOPS!.

Full output: http://webkit-queues.webkit.org/results/7208038

[Per Arne Vollan]

Created attachment 337223 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 337223 [details]
Patch

Clearing flags on attachment: 337223

Committed r230278: <https://trac.webkit.org/changeset/230278>