Summary: | Crash in KJS::JSValue::toObject closing Safari with Inspector open | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Matt Lilek <dev+webkit> | ||||||
Component: | Web Inspector (Deprecated) | Assignee: | Timothy Hatcher <timothy> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | aroben, timothy | ||||||
Priority: | P1 | Keywords: | Regression | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Matt Lilek
2008-04-08 16:18:24 PDT
Created attachment 20414 [details]
Crash log
Crash log for easier reading
I get this crash on Windows as well. Looks like we're crashing inside a call to panel.reset() http://trac.webkit.org/projects/webkit/browser/trunk/WebCore/page/inspector/inspector.js#L624 Here's the crashing line: http://trac.webkit.org/projects/webkit/browser/trunk/WebCore/page/inspector/ElementsPanel.js#L129 var inspectedRootDocument = InspectorController.inspectedWindow().document; Created attachment 20415 [details]
Patch
Comment on attachment 20415 [details]
Patch
130 if (!inspectedWindow) {
131 this.rootDOMNode = null;
132 this.focusedDOMNode = null;
133 }
I think you need to return after setting focusedDOMNode here. Otherwise you'll get an exception later when you access inspectedWindow.document.
r=me
Comment on attachment 20415 [details] Patch Landed in r31743. |