Bug 183706

Summary:

Add _useSystemAppearance to WKView

Product:

WebKit

Reporter:

Megan Gardner <megan_gardner>

Component:

New Bugs

Assignee:

Megan Gardner <megan_gardner>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

thorton, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	thorton: review+

Description Megan Gardner 2018-03-16 14:18:37 PDT

Add _useSystemAppearance to WKView

Comment 1 Megan Gardner 2018-03-16 14:24:56 PDT

Created attachment 335968 [details]
Patch

Comment 2 Megan Gardner 2018-03-16 14:25:30 PDT

<rdar://problem/38516584>

Comment 3 Tim Horton 2018-03-16 15:12:15 PDT

Comment on attachment 335968 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335968&action=review

LGTM. Technically we could probably share the implementation of the defaultAppearance getter in WebViewImpl as well, but that’s just cleanup

> Source/WebKit/UIProcess/API/Cocoa/WKViewPrivate.h:142
> +@property (nonatomic, readwrite, setter=_setUseSystemAppearance:) BOOL _useSystemAppearance WK_API_AVAILABLE(macosx(WK_MAC_TBA));

Maybe a newline before this.

Comment 4 Megan Gardner 2018-03-16 15:23:30 PDT

https://trac.webkit.org/changeset/229684/webkit