Bug 183706

Summary: Add _useSystemAppearance to WKView
Product: WebKit Reporter: Megan Gardner <megan_gardner>
Component: New BugsAssignee: Megan Gardner <megan_gardner>
Status: RESOLVED FIXED    
Severity: Normal CC: thorton, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch thorton: review+

Megan Gardner
Reported 2018-03-16 14:18:37 PDT
Add _useSystemAppearance to WKView
Attachments
Patch (5.62 KB, patch)
2018-03-16 14:24 PDT, Megan Gardner 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Megan Gardner
Comment 1 2018-03-16 14:24:56 PDT
Created attachment 335968 [details] Patch
Megan Gardner
Comment 2 2018-03-16 14:25:30 PDT
<rdar://problem/38516584>
Tim Horton
Comment 3 2018-03-16 15:12:15 PDT
Comment on attachment 335968 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=335968&action=review LGTM. Technically we could probably share the implementation of the defaultAppearance getter in WebViewImpl as well, but that’s just cleanup > Source/WebKit/UIProcess/API/Cocoa/WKViewPrivate.h:142 > +@property (nonatomic, readwrite, setter=_setUseSystemAppearance:) BOOL _useSystemAppearance WK_API_AVAILABLE(macosx(WK_MAC_TBA)); Maybe a newline before this.
Megan Gardner
Comment 4 2018-03-16 15:23:30 PDT
https://trac.webkit.org/changeset/229684/webkit
Note You need to log in before you can comment on or make changes to this bug.