Bug 183704

Summary: Set a trap to catch an infrequent form-related nullptr crash
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit Misc.Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, dbates, ddkilzer, ews-watchlist, japhet, rniwa, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch rniwa: review+

Brent Fulgham
Reported 2018-03-16 12:31:40 PDT
Crash data indicates that we are attempting to process a form where the document's frame has been nulled out. We don't have a reproducible test case to trigger this behavior, so the following patch attempts to trap the unusual condition that seems likely to be the cause of the crash.
Attachments
Patch (4.63 KB, patch)
2018-03-16 12:40 PDT, Brent Fulgham 		rniwa: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2018-03-16 12:40:44 PDT
Created attachment 335961 [details] Patch
David Kilzer (:ddkilzer)
Comment 2 2018-03-16 13:24:09 PDT
Comment on attachment 335961 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=335961&action=review r=me, except I'm not a WebKit2 reviewer. > Source/WebCore/loader/FormState.cpp:54 > + // Beartrap for <rdar://problem/37579354> Uber-Nit. WebKit style says comments should end with a period.
Brent Fulgham
Comment 3 2018-03-16 14:17:29 PDT
Committed r229683: <https://trac.webkit.org/changeset/229683>
Radar WebKit Bug Importer
Comment 4 2018-03-16 14:18:31 PDT
<rdar://problem/38558524>
Note You need to log in before you can comment on or make changes to this bug.