Bug 183690

Summary: Ensure that style is updated when the effective appearance changes
Product: WebKit Reporter: Megan Gardner <megan_gardner>
Component: New BugsAssignee: Megan Gardner <megan_gardner>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, thorton, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch thorton: review+

Megan Gardner
Reported 2018-03-15 20:07:59 PDT
Ensure that style is updated when the effective apperance changes
Attachments
Patch (7.59 KB, patch)
2018-03-15 20:18 PDT, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch (4.85 KB, patch)
2018-03-16 11:18 PDT, Megan Gardner 		thorton: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Megan Gardner
Comment 1 2018-03-15 20:12:17 PDT
<rdar://problem/38385900>
Megan Gardner
Comment 2 2018-03-15 20:18:17 PDT
Created attachment 335922 [details] Patch
Wenson Hsieh
Comment 3 2018-03-16 10:32:31 PDT
Comment on attachment 335922 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=335922&action=review > Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:6188 > + _page->updateForAppearanceChange(); Instead of propagating another IPC message, could we just setNeedsRecalcStyleInAllFrames() after setting the default appearance in the web process?
Tim Horton
Comment 4 2018-03-16 10:34:49 PDT
Comment on attachment 335922 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=335922&action=review > Source/WebCore/ChangeLog:9 > + Only exposing a function to outside webcore, no tests needed. WebCore >> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:6188 >> + _page->updateForAppearanceChange(); > > Instead of propagating another IPC message, could we just setNeedsRecalcStyleInAllFrames() after setting the default appearance in the web process? Agree! Tinier patch. > Source/WebKitLegacy/mac/WebView/WebView.mm:5216 > +#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400 Not really necessary. > Source/WebKitLegacy/mac/WebView/WebView.mm:5219 > + if (auto page = _private->page) { Early return instead of this.
Megan Gardner
Comment 5 2018-03-16 11:18:11 PDT
Created attachment 335953 [details] Patch
Tim Horton
Comment 6 2018-03-16 11:28:52 PDT
Comment on attachment 335953 [details] Patch Plz address previous comments.
Megan Gardner
Comment 7 2018-03-16 11:48:40 PDT
https://trac.webkit.org/changeset/229679/webkit
Note You need to log in before you can comment on or make changes to this bug.