Summary: | ServiceWorkerClientFetch::didReceiveData should check for m_encodedDataLength | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||||||
Component: | Service Workers | Assignee: | youenn fablet <youennf> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | cdumez, commit-queue, ews-watchlist, rniwa, ryanhaddad, webkit-bug-importer | ||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||
Version: | Other | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Attachments: |
|
Description
youenn fablet
2018-03-15 11:07:38 PDT
Created attachment 335864 [details]
Patch
This crash happens because ServiceWorkerClientFetch can call m_loader->didReceiveBuffer at two different places (IPC or completion handler for response check). In which case, we free the buffer and set back m_encodedLength to zero. Created attachment 335882 [details]
Patch
Comment on attachment 335882 [details] Patch Attachment 335882 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/6970917 Number of test failures exceeded the failure limit. Created attachment 335895 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 335882 [details] Patch Attachment 335882 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/6971035 Number of test failures exceeded the failure limit. Created attachment 335902 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 335882 [details]
Patch
r- given test failures :)
Created attachment 336129 [details]
Patch
Comment on attachment 336129 [details] Patch Clearing flags on attachment: 336129 Committed r229774: <https://trac.webkit.org/changeset/229774> All reviewed patches have been landed. Closing bug. |