Bug 18364

Summary: [GTK] Buttons activated with the keyboard should be painted as clicked
Product: WebKit Reporter: Marco Barisione <marco.barisione>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, jmalonzo, mrobinson, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch for this issue none

Marco Barisione
Reported 2008-04-08 07:19:11 PDT
When activating a button with the keyboard it should be painted as pressed.
Attachments
Patch for this issue (2.42 KB, patch)
2010-10-09 12:24 PDT, Martin Robinson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jan Alonzo
Comment 1 2008-10-18 04:19:39 PDT
marco, pressed or focused? can you please confirm if this doesn't occur in ToT yet? cheersm
Martin Robinson
Comment 2 2010-10-08 18:31:20 PDT
I can confirm that tabbing to a button and pressing space does not cause the button to be shown as pressed. Compare the behavior that happens in Chromium or Firefox.
Martin Robinson
Comment 3 2010-10-09 12:24:57 PDT
Created attachment 70360 [details] Patch for this issue
Gustavo Noronha (kov)
Comment 4 2010-10-11 14:14:00 PDT
Comment on attachment 70360 [details] Patch for this issue Cunning.
Martin Robinson
Comment 5 2010-10-11 14:21:00 PDT
Comment on attachment 70360 [details] Patch for this issue Clearing flags on attachment: 70360 Committed r69526: <http://trac.webkit.org/changeset/69526>
Martin Robinson
Comment 6 2010-10-11 14:21:04 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 7 2010-10-11 15:44:59 PDT
http://trac.webkit.org/changeset/69526 might have broken GTK Linux 64-bit Debug The following tests are not passing: editing/selection/move-past-trailing-space.html fast/css/shadow-multiple.html fast/text/shadow-no-blur.html
Note You need to log in before you can comment on or make changes to this bug.